Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #1364

wants to merge 1 commit into from

Conversation

Katy4S
Copy link

@Katy4S Katy4S commented Feb 17, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 Your code is well-structured and meets the core requirements effectively. There are a couple of minor improvements you could consider: removing the redundant author's name display in PostInfo.jsx and addressing the default export issue in App.jsx. These changes will enhance clarity and consistency. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

);
};

export default App;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component App is already exported as a named export on line 8. Having a default export for the same component can lead to confusion and potential import issues. Consider removing the default export or ensuring consistency in how the component is imported elsewhere in your application.

Comment on lines +9 to +11
<p className="PostInfo__user">Author: {post.user.name}</p>
<div className="UserInfo">
<p className="UserInfo__name">{post.user.name}</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author's name is displayed twice: once in the PostInfo__user paragraph and again in the UserInfo__name paragraph. Consider removing one of these to avoid redundancy and improve clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants