Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1356

wants to merge 1 commit into from

Conversation

Bankir4ik87
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Feb 12, 2025
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core requirements. The only minor suggestion is to remove the unnecessary || null in the getCommentsByPostId function, as filter will always return an array. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/App.jsx

function getCommentsByPostId(postId) {
return (
commentsFromServer.filter(comment => comment.postId === postId) || null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of || null is unnecessary here. The filter method always returns an array, so you don't need to default to null. You can safely remove || null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bankir4ik87 @mateacademy-ai-mentor