add task solution #2743
add task solution #2743
Conversation
There was a problem hiding this comment.
Great job on implementing the task! 🎉 Your code meets the core requirements, and the functionality is working as expected. There are just a couple of minor improvements you can make: removing the redundant onClick handler on the submit button and ensuring efficient use of the setMovies function. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <NewMovie /* onAdd={(movie) => {}} */ /> | ||
| <NewMovie | ||
| onAdd={(movie: Movie) => { | ||
| setMovies([...movies, movie]); |
There was a problem hiding this comment.
You are using the spread operator to create a new array when updating the state with setMovies. According to the checklist, if you are using a non-mutating array method, you don't need to create a copy of the array. However, in this case, using the spread operator is necessary to add a new movie to the existing list, so this is acceptable.
|
|
||
| <div className="field is-grouped"> | ||
| <div className="control"> | ||
| <button | ||
| type="submit" | ||
| data-cy="submit-button" | ||
| className="button is-link" | ||
| disabled={!isValid()} | ||
| onClick={handleSubmit} |
There was a problem hiding this comment.
The onClick handler for the submit button is redundant because the form's onSubmit event already handles the submission. You can safely remove onClick={handleSubmit} to avoid unnecessary duplication.
DEMO LINK