Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
145 changes: 113 additions & 32 deletions src/components/NewMovie/NewMovie.tsx
Original file line number Diff line number Diff line change
@@ -1,42 +1,123 @@
import { useState } from 'react';
import { TextField } from '../TextField';
import { MoviesList } from '../MoviesList';

export const NewMovie = () => {
export interface Movie {
title: string;
description: string;
imgUrl: string;
imdbUrl: string;
imdbId: string;
}

interface NewMovieProps {
onAdd: (movie: Movie) => void;
}

export const NewMovie: React.FC<NewMovieProps> = ({ onAdd }) => {
// Increase the count after successful form submission
// to reset touched status of all the `Field`s
const [count] = useState(0);
const [count, setCount] = useState(0);

const [title, setTitle] = useState('');

const [description, setDescription] = useState('');

const [imgUrl, setImgUrl] = useState('');

const [imdbUrl, setImdbUrl] = useState('');

const [imdbId, setImdbId] = useState('');

const [movies, setMovies] = useState<Movie[]>([]);

const isFormValid =
title.trim() && imgUrl.trim() && imdbUrl.trim() && imdbId.trim();
Comment on lines +34 to +35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isFormValid variable is used to determine if the form can be submitted. Ensure that all required fields are correctly validated. Currently, it checks if title, imgUrl, imdbUrl, and imdbId are non-empty, which seems correct given the required fields. However, ensure this logic aligns with your form validation requirements.


const reset = () => {
setTitle('');
setImgUrl('');
setDescription('');
setImdbUrl('');
setImdbId('');
};

const handleAdd = (event: React.FormEvent) => {
event.preventDefault();

if (!isFormValid) {
return;
}

const newMovie: Movie = { title, imgUrl, imdbUrl, imdbId, description };

setMovies(prevMovies => [...prevMovies, newMovie]);

onAdd(newMovie);

reset();

setCount(prev => prev + 1);
};

return (
<form className="NewMovie" key={count}>
<h2 className="title">Add a movie</h2>

<TextField
name="title"
label="Title"
value=""
onChange={() => {}}
required
/>

<TextField name="description" label="Description" value="" />

<TextField name="imgUrl" label="Image URL" value="" />

<TextField name="imdbUrl" label="Imdb URL" value="" />

<TextField name="imdbId" label="Imdb ID" value="" />

<div className="field is-grouped">
<div className="control">
<button
type="submit"
data-cy="submit-button"
className="button is-link"
>
Add
</button>
<>
<form className="NewMovie" key={count} onSubmit={handleAdd}>
<h2 className="title">Add a movie</h2>

<TextField
name="title"
label="Title"
value={title}
onChange={(value: string) => setTitle(value)}
required
/>

<TextField
name="description"
label="Description"
onChange={(value: string) => setDescription(value)}
value={description}
/>

<TextField
name="imgUrl"
label="Image URL"
value={imgUrl}
onChange={(value: string) => setImgUrl(value)}
required
/>

<TextField
name="imdbUrl"
label="Imdb URL"
value={imdbUrl}
onChange={(value: string) => setImdbUrl(value)}
required
/>

<TextField
name="imdbId"
label="Imdb ID"
value={imdbId}
onChange={(value: string) => setImdbId(value)}
required
/>

<div className="field is-grouped">
<div className="control">
<button
type="submit"
data-cy="submit-button"
className="button is-link"
disabled={!isFormValid}
>
Add
</button>
</div>
</div>
</div>
</form>
</form>
<MoviesList movies={movies} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the MoviesList component is correctly implemented to handle the movies prop. Verify that it exists and is capable of rendering the list of movies passed to it.

</>
);
};
Loading