Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Movies list done #2147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Movies list done #2147

wants to merge 2 commits into from

Conversation

hyrych-max
Copy link

sTorba24
sTorba24 suggested changes Feb 10, 2024
View reviewed changes
Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Some things to improve

but it's valid already
image

src/components/TextField/TextField.tsx Outdated
// generage a unique id once on component load
const [id] = useState(() => `${name}-${getRandomDigits()}`);

// To show errors only if the field was touched (onBlur)
const [touched, setTouched] = useState(false);
const hasError = touched && required && !value;
const validation = pattern.test(value);
const invalidData = validation !== null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const invalidData = validation !== null
const invalidData = validation

@hyrych-max hyrych-max requested a review from sTorba24 February 11, 2024 21:34
etojeDenys
etojeDenys approved these changes Feb 12, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@sTorba24 sTorba24 Awaiting requested review from sTorba24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyrych-max @sTorba24 @etojeDenys