add react form #2125
Open
add react form #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viktor-Kost
suggested changes
Jan 23, 2024
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
13
to
19
| // const [count, setCount] = useState(0); | ||
|
|
||
| // const [title, setTitle] = useState(''); | ||
| // const [description, setDescription] = useState(''); | ||
| // const [imgUrl, setImgUrl] = useState(''); | ||
| // const [imdbUrl, setImdbUrl] = useState(''); | ||
| // const [imdbId, setImdbId] = useState(''); |
src/components/NewMovie/NewMovie.tsx
Outdated
| // Increase the count after successful form submission | ||
| // to reset touched status of all the `Field`s | ||
| const [count] = useState(0); | ||
|
|
||
| // const [count, setCount] = useState(0); |
There was a problem hiding this comment.
you should have this state to increase counter on submit
src/components/NewMovie/NewMovie.tsx
Outdated
| // const [imdbUrl, setImdbUrl] = useState(''); | ||
| // const [imdbId, setImdbId] = useState(''); | ||
|
|
||
| const [movieData, setMovieData] = useState({ |
There was a problem hiding this comment.
move default state object to a variable
| } = movieData; | ||
|
|
||
| const reset = () => { | ||
| setMovieData((prevData) => ({ |
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
80
to
85
| onChange={(newValue) => setMovieData( | ||
| { | ||
| ...movieData, | ||
| title: newValue, | ||
| }, | ||
| )} |
There was a problem hiding this comment.
move this onClick handler to an own function so you'll reuse it for cases below as well
Viktor-Kost
approved these changes
Jan 23, 2024
Comment on lines
+10
to
+16
| const defaultMovieData = { | ||
| title: '', | ||
| description: '', | ||
| imgUrl: '', | ||
| imdbUrl: '', | ||
| imdbId: '', | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK