add solution #2115
Open
add solution #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilWeda
suggested changes
Jan 19, 2024
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
26
to
29
| const isFieldsFill = title.trim() !== '' | ||
| && imgUrl.trim() !== '' | ||
| && imdbUrl.trim() !== '' | ||
| && imdbId.trim() !== ''; |
There was a problem hiding this comment.
Suggested change
| const isFieldsFill = title.trim() !== '' | |
| && imgUrl.trim() !== '' | |
| && imdbUrl.trim() !== '' | |
| && imdbId.trim() !== ''; | |
| const isFieldsFill = !title.trim() | |
| && !imgUrl.trim() | |
| && !imdbUrl.trim() | |
| && !imdbId.trim(); |
Try rewriting for the best readability!
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
10
to
14
| const [title, setTitle] = useState(''); | ||
| const [description, setDescription] = useState(''); | ||
| const [imgUrl, setImgUrl] = useState(''); | ||
| const [imdbUrl, setImdbUrl] = useState(''); | ||
| const [imdbId, setImdbId] = useState(''); |
There was a problem hiding this comment.
Try to think how you can use one state for all form data
src/App.tsx
Outdated
|
|
||
| export const App = () => { | ||
| const [movies, setMovies] = useState(moviesFromServer); | ||
| const [newMovieId, setNewMovieId] = useState('s'); |
There was a problem hiding this comment.
what does 's' ? Fix naming or remove this value
src/App.tsx
Outdated
| const [newMovieId, setNewMovieId] = useState('s'); | ||
| const addMovie = (movie: Movie) => { | ||
| setMovies(existingMovies => [...existingMovies, movie]); | ||
| setNewMovieId(Math.random().toString(16).slice(2)); |
There was a problem hiding this comment.
You can create a helper function that return your generated id
DanilWeda
approved these changes
Jan 22, 2024
Comment on lines
+18
to
+22
| // const [title, setTitle] = useState(''); | ||
| // const [description, setDescription] = useState(''); | ||
| // const [imgUrl, setImgUrl] = useState(''); | ||
| // const [imdbUrl, setImdbUrl] = useState(''); | ||
| // const [imdbId, setImdbId] = useState(''); |
| import './App.scss'; | ||
| import { MoviesList } from './components/MoviesList'; | ||
| import { NewMovie } from './components/NewMovie'; | ||
| import moviesFromServer from './api/movies.json'; | ||
| import { Movie } from './types/Movie'; | ||
|
|
||
| const getNewId = () => Math.random().toString(16).slice(2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK