Done!(try1) #2112
Open
Done!(try1) #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilWeda
suggested changes
Jan 18, 2024
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
29
to
33
| const isDisabled = !( | ||
| fieldsOfMovie.title | ||
| && fieldsOfMovie.imgUrl | ||
| && fieldsOfMovie.imdbUrl | ||
| && fieldsOfMovie.imdbId); |
src/components/NewMovie/NewMovie.tsx
Outdated
| imdbId: '', | ||
| }; | ||
|
|
||
| type Props = { |
There was a problem hiding this comment.
Suggested change
| type Props = { | |
| interface Props = { |
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
39
to
43
| title: fieldsOfMovie.title, | ||
| description: fieldsOfMovie.description, | ||
| imgUrl: fieldsOfMovie.imgUrl, | ||
| imdbUrl: fieldsOfMovie.imdbUrl, | ||
| imdbId: fieldsOfMovie.imdbId, |
There was a problem hiding this comment.
Suggested change
| title: fieldsOfMovie.title, | |
| description: fieldsOfMovie.description, | |
| imgUrl: fieldsOfMovie.imgUrl, | |
| imdbUrl: fieldsOfMovie.imdbUrl, | |
| imdbId: fieldsOfMovie.imdbId, | |
| ...fieldsOfMovie, |
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
50
to
52
| const changeFieldHandler = (name: Field, value: string) => { | ||
| setFieldsOfMovie(prevFields => ({ ...prevFields, [name]: value })); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const changeFieldHandler = (name: Field, value: string) => { | |
| setFieldsOfMovie(prevFields => ({ ...prevFields, [name]: value })); | |
| }; | |
| const changeFieldHandler = (key: Field) => ( value: string) => { | |
| setFieldsOfMovie(prevFields => ({ ...prevFields, [key]: value })); | |
| }; |
You can make it closure for best view )
src/components/NewMovie/NewMovie.tsx
Outdated
| value="" | ||
| onChange={() => {}} | ||
| value={fieldsOfMovie.title} | ||
| onChange={(value) => changeFieldHandler('title', value)} |
There was a problem hiding this comment.
Suggested change
| onChange={(value) => changeFieldHandler('title', value)} | |
| onChange={changeFieldHandler('title')} |
And use it so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK