task sol #2103
Open
task sol #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaneznayou
approved these changes
Jan 16, 2024
SerhiiKirik
approved these changes
Jan 17, 2024
| const isDisabled = !title.trim() || !imgUrl.trim() | ||
| || !imdbUrl.trim() || !imdbId.trim(); | ||
|
|
||
| const reset = () => { |
There was a problem hiding this comment.
Make all code in 1 style)
Suggested change
| const reset = () => { | |
| const handleReset = () => { |
| const handleSubmit = (event: React.FormEvent) => { | ||
| event.preventDefault(); | ||
|
|
||
| setCount(count + 1); |
There was a problem hiding this comment.
do it with functional setState
Suggested change
| setCount(count + 1); | |
| setCount(() => ...); |
Comment on lines
+34
to
+40
| onAdd({ | ||
| title, | ||
| description, | ||
| imgUrl, | ||
| imdbUrl, | ||
| imdbId, | ||
| }); |
There was a problem hiding this comment.
Would be better if you first create some variable and put this variable to function
Suggested change
| onAdd({ | |
| title, | |
| description, | |
| imgUrl, | |
| imdbUrl, | |
| imdbId, | |
| }); | |
| onAdd(newMovie); |
| // Increase the count after successful form submission | ||
| // to reset touched status of all the `Field`s | ||
| const [count] = useState(0); | ||
| const [count, setCount] = useState(0); | ||
| const [title, setTitle] = useState(''); |
There was a problem hiding this comment.
also, you can combine all these states to 1, form
like
const [form, setForm] = useState({ ... })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
npm testto ensure your solution is correct.<your_account>with your Github username in the DEMO LINK and add it to the PR description.