message

mate-academy · Jan 29, 2024 · f82a177 · f82a177
1 parent 120d694
commit f82a177
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/src/App.tsx b/src/App.tsx
@@ -5,13 +5,11 @@ import { NewMovie } from './components/NewMovie';
 import moviesFromServer from './api/movies.json';
 import { Movie } from './types/Movie';
 
-const initMovies = [...moviesFromServer];
-
 export const App = () => {
-  const [movies, setMovies] = useState(initMovies);
+  const [movies, setMovies] = useState(moviesFromServer);
 
   const onAdd = (movie: Movie) => {
-    setMovies([...initMovies, movie]);
+    setMovies([...movies, movie]);
   };
 
   return (

diff --git a/src/components/NewMovie/NewMovie.tsx b/src/components/NewMovie/NewMovie.tsx
@@ -19,7 +19,7 @@ export const NewMovie: React.FC<Props> = ({ onAdd }) => {
     imdbId: '',
   });
 
-  const ifAllFieldsFilled = newMovie.title.trim() && newMovie.imgUrl.trim()
+  const isAllFieldsFilled = newMovie.title.trim() && newMovie.imgUrl.trim()
   && newMovie.imdbUrl.trim() && newMovie.imdbId.trim();
 
   const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
@@ -29,19 +29,21 @@ export const NewMovie: React.FC<Props> = ({ onAdd }) => {
   };
 
   const reset = () => {
-    newMovie.title = '';
-    newMovie.description = '';
-    newMovie.imgUrl = '';
-    newMovie.imdbUrl = '';
-    newMovie.imdbId = '';
+    setNewMovie({
+      title: '',
+      description: '',
+      imgUrl: '',
+      imdbUrl: '',
+      imdbId: '',
+    });
   };
 
   const handleFormOnSubmit = (event: React.FormEvent) => {
     event.preventDefault();
 
     setCount(counter => counter + 1);
 
-    if (!ifAllFieldsFilled) {
+    if (!isAllFieldsFilled) {
       return;
     }
 
@@ -78,7 +80,6 @@ export const NewMovie: React.FC<Props> = ({ onAdd }) => {
         value={newMovie.imgUrl}
         onChange={handleChange}
         required
-        // isValidUrl={isValidUrl(imgUrl)}
 
       />
 
@@ -88,7 +89,6 @@ export const NewMovie: React.FC<Props> = ({ onAdd }) => {
         value={newMovie.imdbUrl}
         onChange={handleChange}
         required
-        // isValidUrl={isValidUrl(imgUrl)}
 
       />
 
@@ -107,7 +107,7 @@ export const NewMovie: React.FC<Props> = ({ onAdd }) => {
             type="submit"
             data-cy="submit-button"
             className="button is-link"
-            disabled={!ifAllFieldsFilled}
+            disabled={!isAllFieldsFilled}
           >
             Add
           </button>

diff --git a/src/components/TextField/TextField.tsx b/src/components/TextField/TextField.tsx
@@ -23,7 +23,6 @@ export const TextField: React.FC<Props> = ({
   placeholder = `Enter ${label}`,
   required = false,
   onChange = () => {},
-  // isValidUrl = () => {},
 }) => {
   // generage a unique id once on component load
   const [id] = useState(() => `${name}-${getRandomDigits()}`);