Skip to content

Commit

Permalink
add solution
Browse files Browse the repository at this point in the history
  • Loading branch information
galenwood committed Jan 28, 2025
1 parent 9663976 commit 7edace5
Show file tree
Hide file tree
Showing 4 changed files with 99 additions and 21 deletions.
12 changes: 10 additions & 2 deletions src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,23 @@ import './App.scss';
import { MoviesList } from './components/MoviesList';
import { NewMovie } from './components/NewMovie';
import moviesFromServer from './api/movies.json';
import { useState } from 'react';
import { Movie } from './types/Movie';

export const App = () => {
const [movies, setMovies] = useState(moviesFromServer);

return (
<div className="page">
<div className="page-content">
<MoviesList movies={moviesFromServer} />
<MoviesList movies={movies} />
</div>
<div className="sidebar">
<NewMovie /* onAdd={(movie) => {}} */ />
<NewMovie
onAdd={(movie: Movie) => {
setMovies([...movies, movie]);
}}
/>
</div>
</div>
);
Expand Down
4 changes: 4 additions & 0 deletions src/components/MoviesList/MoviesList.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@
grid-template-columns: repeat(auto-fill, minmax(250px, 1fr));
gap: 20px;
}

.card {
height: 100%;
}
90 changes: 78 additions & 12 deletions src/components/NewMovie/NewMovie.tsx
Original file line number Diff line number Diff line change
@@ -1,37 +1,103 @@
import { useState } from 'react';
import React, { useState } from 'react';
import { TextField } from '../TextField';
import { Movie } from '../../types/Movie';

export const NewMovie = () => {
// Increase the count after successful form submission
// to reset touched status of all the `Field`s
const [count] = useState(0);
type Props = {
onAdd: (movie: Movie) => void;
};

export const NewMovie: React.FC<Props> = ({ onAdd }) => {
const [count, setCount] = useState(0);
const [newMovie, setNewMovie] = useState({
title: '',
description: '',
imgUrl: '',
imdbUrl: '',
imdbId: '',
});

const { title, description, imgUrl, imdbUrl, imdbId } = newMovie;

const isValid = () => {
return Boolean(
title.trim() && imgUrl.trim() && imdbUrl.trim() && imdbId.trim(),
);
};

const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => {
const { name, value } = event.target;

setNewMovie(prevMovie => ({ ...prevMovie, [name]: value }));
};

const handleSubmit = (event: React.FormEvent) => {
event.preventDefault();

if (!isValid()) {
return;
}

onAdd(newMovie);
setCount(count + 1);
setNewMovie({
title: '',
description: '',
imgUrl: '',
imdbUrl: '',
imdbId: '',
});
};

return (
<form className="NewMovie" key={count}>
<form className="NewMovie" key={count} onSubmit={handleSubmit}>
<h2 className="title">Add a movie</h2>

<TextField
name="title"
label="Title"
value=""
onChange={() => {}}
value={title}
onChange={handleChange}
required
/>

<TextField name="description" label="Description" value="" />
<TextField
name="description"
label="Description"
value={description}
onChange={handleChange}
/>

<TextField name="imgUrl" label="Image URL" value="" />
<TextField
name="imgUrl"
label="Image URL"
value={imgUrl}
onChange={handleChange}
required
/>

<TextField name="imdbUrl" label="Imdb URL" value="" />
<TextField
name="imdbUrl"
label="Imdb URL"
value={imdbUrl}
onChange={handleChange}
required
/>

<TextField name="imdbId" label="Imdb ID" value="" />
<TextField
name="imdbId"
label="Imdb ID"
value={imdbId}
onChange={handleChange}
required
/>

<div className="field is-grouped">
<div className="control">
<button
type="submit"
data-cy="submit-button"
className="button is-link"
disabled={!isValid()}
>
Add
</button>
Expand Down
14 changes: 7 additions & 7 deletions src/components/TextField/TextField.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ type Props = {
label?: string;
placeholder?: string;
required?: boolean;
onChange?: (newValue: string) => void;
onChange?: (event: React.ChangeEvent<HTMLInputElement>) => void;
};

function getRandomDigits() {
Expand All @@ -22,12 +22,9 @@ export const TextField: React.FC<Props> = ({
required = false,
onChange = () => {},
}) => {
// generate a unique id once on component load
const [id] = useState(() => `${name}-${getRandomDigits()}`);

// To show errors only if the field was touched (onBlur)
const [touched, setTouched] = useState(false);
const hasError = touched && required && !value;
const hasError = touched && required && !value.trim();

return (
<div className="field">
Expand All @@ -39,14 +36,17 @@ export const TextField: React.FC<Props> = ({
<input
type="text"
id={id}
name={name}
data-cy={`movie-${name}`}
className={classNames('input', {
'is-danger': hasError,
})}
placeholder={placeholder}
value={value}
onChange={event => onChange(event.target.value)}
onBlur={() => setTouched(true)}
onChange={onChange}
onBlur={() => {
setTouched(true);
}}
/>
</div>

Expand Down

0 comments on commit 7edace5

Please sign in to comment.