Develop #1769
Develop #1769
Conversation
src/App.tsx
Outdated
| </td> | ||
| return ( | ||
| <main className="section container"> | ||
| {selectedGood === '' ? ( |
There was a problem hiding this comment.
| {selectedGood === '' ? ( | |
| {!selectedGood ? ( |
src/App.tsx
Outdated
| data-cy="ClearButton" | ||
| type="button" | ||
| className="delete ml-3" | ||
| onClick={() => this.setState({ selectedGood: '' })} |
There was a problem hiding this comment.
you have handler handleRemoveGood
| key={index} | ||
| data-cy="Good" | ||
| className={ | ||
| selectedGood === good ? 'has-background-success-light' : '' |
There was a problem hiding this comment.
| selectedGood === good ? 'has-background-success-light' : '' | |
| 'has-background-success-light' : selectedGood === good |
There was a problem hiding this comment.
className={
selectedGood === good && 'has-background-success-light'
}
Type 'false | "has-background-success-light"' is not assignable to type 'string | undefined'.
There was a problem hiding this comment.
Yea i guess that this syntax requires classnames package
src/App.tsx
Outdated
| <td> | ||
| {selectedGood === good ? ( | ||
| <button | ||
| data-cy="RemoveButton" | ||
| type="button" | ||
| className="button is-info" | ||
| onClick={this.handleRemoveGood} | ||
| > | ||
| - | ||
| </button> | ||
| ) : ( | ||
| <button | ||
| data-cy="AddButton" | ||
| type="button" | ||
| className="button" | ||
| onClick={() => this.handleSelectGood(good)} | ||
| > | ||
| + | ||
| </button> | ||
| )} | ||
| </td> |
There was a problem hiding this comment.
just change your content(+/-) using condition, and improve your handleRemoveGood by checking inside is selected good === good, and clear if true
| key={index} | ||
| data-cy="Good" | ||
| className={ | ||
| selectedGood === good ? 'has-background-success-light' : '' |
There was a problem hiding this comment.
Yea i guess that this syntax requires classnames package
| {goods.map((good, index) => { | ||
| return ( | ||
| <tr | ||
| key={index} |
There was a problem hiding this comment.
Using the index as a key is not a good practice. In this case, it doesn’t matter, but remember to avoid it. If you have a unique value, use that instead.
DEMO LINK