Develop #1768
Open
Develop #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalia-klonowska
suggested changes
Jul 31, 2024
src/App.tsx
Outdated
|
|
||
| render() { | ||
| const title = | ||
| this.state.selectedGood === '' ? ( |
There was a problem hiding this comment.
destructure state so you don't need to repeat this.state every time ;)
src/App.tsx
Outdated
Comment on lines
61
to
65
| className={ | ||
| this.state.selectedGood === good | ||
| ? 'has-background-success-light' | ||
| : '' | ||
| } |
There was a problem hiding this comment.
use classnames library to improve readability of conditional classes
src/App.tsx
Outdated
| data-cy="RemoveButton" | ||
| type="button" | ||
| className="button is-info" | ||
| onClick={() => this.deleteGood()} |
There was a problem hiding this comment.
checklist: If your method don't get any argument, you don't need to create new arrow function. Just pass your method.
src/App.tsx
Outdated
|
|
||
|
|
||
|
|
||
| <tr data-cy="Good" className="has-background-success-light"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEMO LINK] https://keex1k.github.io/react_goods-selector/