Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1219

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #1219

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
929aa09
almost done
DmytroHoncharuk Jan 13, 2025
50d2048
implemented add and delete of comments
DmytroHoncharuk Jan 13, 2025
3d5c58e
solution
DmytroHoncharuk Jan 13, 2025
06fba62
fix bugs
DmytroHoncharuk Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 100 additions & 39 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,57 +4,118 @@ import 'bulma/css/bulma.css';
import '@fortawesome/fontawesome-free/css/all.css';
import './App.scss';

import { PostsList } from './components/PostsList';
import { PostDetails } from './components/PostDetails';
import { UserSelector } from './components/UserSelector';
import React, { useEffect } from 'react';
import { User } from './types/User';
import { getPostsOfUser, getUsers } from './utils/api';
import { Post } from './types/Post';
import { PostsList } from './components/PostsList';
import { Loader } from './components/Loader';
import { PostDetails } from './components/PostDetails';

export const App = () => (
<main className="section">
<div className="container">
<div className="tile is-ancestor">
<div className="tile is-parent">
<div className="tile is-child box is-success">
<div className="block">
<UserSelector />
</div>
export const App = () => {
const [usersFromServer, setUsersFromServer] = React.useState<User[]>();
const [postsFromServer, setPostsFromServer] = React.useState<Post[]>();

<div className="block" data-cy="MainContent">
<p data-cy="NoSelectedUser">No user selected</p>
const [chosenUser, setChosenUser] = React.useState<User | null>(null);
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const [postError, setPostError] = React.useState(false);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postError state is initialized but not used in the component logic. Consider using it to handle errors related to fetching posts or remove it if it's unnecessary.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postError state is set to true when an error occurs while fetching posts, but it is not utilized effectively in the component's logic. Ensure that this state is used to display an appropriate error message or take necessary actions when a post fetch error occurs.

const [isPostsLoading, setIsPostsLoading] = React.useState(false);
const [activePost, setActivePost] = React.useState<Post | null>(null);

<Loader />
useEffect(() => {
const fetchUsers = async () => {
try {
const currentUsers = await getUsers();

<div
className="notification is-danger"
data-cy="PostsLoadingError"
>
Something went wrong!
</div>
setUsersFromServer(currentUsers);
} catch (err) {
} finally {
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error handling block in the fetchUsers function is empty. Consider adding logic to handle errors, such as setting an error state or logging the error, to improve the robustness of the application.

};

fetchUsers();
}, []);

<div className="notification is-warning" data-cy="NoPostsYet">
No posts yet
useEffect(() => {
const fetchPosts = async () => {
setIsPostsLoading(true);
try {
const currentPosts = await getPostsOfUser(chosenUser?.id ?? 0);

setPostsFromServer(currentPosts);
} catch (err) {
setPostError(true);
} finally {
setIsPostsLoading(false);
}
};

if (chosenUser) {
setActivePost(null);
fetchPosts();
}
}, [chosenUser]);

return (
<main className="section">
<div className="container">
<div className="tile is-ancestor">
<div className="tile is-parent">
<div className="tile is-child box is-success">
<div className="block">
<UserSelector
users={usersFromServer ?? []}
chosenUser={chosenUser}
chooseUser={setChosenUser}
/>
</div>

<PostsList />
<div className="block" data-cy="MainContent">
{!chosenUser ? (
<p data-cy="NoSelectedUser">No user selected</p>
) : isPostsLoading ? (
<Loader />
) : postError ? (
<div
className="notification is-danger"
data-cy="PostsLoadingError"
>
Something went wrong!
</div>
) : postsFromServer?.length === 0 ? (
<div className="notification is-warning" data-cy="NoPostsYet">
No posts yet
</div>
) : (
<PostsList
posts={postsFromServer}
activePost={activePost}
choosePost={setActivePost}
/>
)}
</div>
</div>
</div>
</div>

<div
data-cy="Sidebar"
className={classNames(
'tile',
'is-parent',
'is-8-desktop',
'Sidebar',
'Sidebar--open',
)}
>
<div className="tile is-child box is-success ">
<PostDetails />
<div
data-cy="Sidebar"
className={classNames(
'tile',
'is-parent',
'is-8-desktop',
'Sidebar',
{ 'Sidebar--open': activePost },
)}
>
{activePost && (
<div className="tile is-child box is-success">
<PostDetails post={activePost} />
</div>
)}
</div>
</div>
</div>
</div>
</main>
);
</main>
);
};
Loading
Loading