solution #1022
Open
solution #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sTorba24
suggested changes
Jan 20, 2024
README.md
Outdated
| @@ -10,7 +10,7 @@ form to add new comments. | |||
| 1. Initially the `App` shows the `UserSelector` and a paragraph `No user selected` in the main content block. | |||
| - load users from the API on page load; | |||
| - implement the `UserSelector` as a dropdown using the given markup; | |||
| 1. When a user is selected load the user's posts form [the API](https://mate-academy.github.io/fe-students-api/) and show them using a table in the main content clock; | |||
| 1. When a user is selected load the user's posts form [the API](https://oleksiy-uchaev.github.io/fe-students-api/) and show them using a table in the main content clock; | |||
There was a problem hiding this comment.
you shouldn't change this link, it's mate-academy api
Comment on lines
41
to
45
| { 'is-active': comments.length === 0 }, | ||
| { | ||
| 'is-hidden': comments.length !== 0 | ||
| || loadType === Load.Comments, | ||
| })} |
There was a problem hiding this comment.
Suggested change
| { 'is-active': comments.length === 0 }, | |
| { | |
| 'is-hidden': comments.length !== 0 | |
| || loadType === Load.Comments, | |
| })} | |
| { 'is-active': !comments.length }, | |
| { | |
| 'is-hidden': comments.length | |
| || loadType === Load.Comments, | |
| })} |
volodymyr-soltys97
suggested changes
Jan 20, 2024
| href={`mailto:${comment.email}`} | ||
| data-cy="CommentAuthor" | ||
| > | ||
| {comment.name} |
There was a problem hiding this comment.
Use the destruction for comment
|
|
||
| return ( | ||
| <> | ||
| {comments.length > 0 && <p className="title is-4">Comments:</p>} |
There was a problem hiding this comment.
Suggested change
| {comments.length > 0 && <p className="title is-4">Comments:</p>} | |
| {!!comments.length && <p className="title is-4">Comments:</p>} |
| <button | ||
| type="reset" | ||
| className="button is-link is-light" | ||
| onClick={() => handleClearForm()} |
There was a problem hiding this comment.
Suggested change
| onClick={() => handleClearForm()} | |
| onClick={handleClearForm} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK