solution #1013
Open
solution #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Jan 12, 2024
src/components/NewCommentForm.tsx
Outdated
| className="input is-danger" | ||
| className={cn('input', { 'is-danger': hasNameError })} | ||
| value={inputName} | ||
| onChange={event => handleChangeName(event)} |
There was a problem hiding this comment.
Suggested change
| onChange={event => handleChangeName(event)} | |
| onChange={handleChangeName} |
src/components/PostDetails.tsx
Outdated
| aria-label="delete" | ||
| {!error && Boolean(comments.length) | ||
| && !isLoadingComments | ||
| && comments.map(comment => ( |
There was a problem hiding this comment.
Use a destruction for comment
src/components/PostsList.tsx
Outdated
Comment on lines
53
to
55
| {openPostId === post.id | ||
| ? 'Close' | ||
| : 'Open'} |
There was a problem hiding this comment.
Suggested change
| {openPostId === post.id | |
| ? 'Close' | |
| : 'Open'} | |
| {openPostId === post.id ? 'Close' : 'Open'} |
src/components/UserSelector.tsx
Outdated
Comment on lines
37
to
43
| {!selectedUser | ||
| ? ( | ||
| <span>Choose a user</span> | ||
| ) | ||
| : ( | ||
| <span>{selectedUser?.name}</span> | ||
| )} |
There was a problem hiding this comment.
This check can be placed inside the span tag
loralevitska
suggested changes
Jan 13, 2024
src/App.tsx
Outdated
Comment on lines
115
to
119
| {(!isLoadingPosts | ||
| && posts.length > 0 | ||
| && selectedUser | ||
| && !errorPosts) | ||
| && ( |
There was a problem hiding this comment.
Long expression better move to variable with meaningful variable naming
src/components/PostsList.tsx
Outdated
| <td data-cy="PostId">{post.id}</td> | ||
|
|
||
| <td data-cy="PostTitle"> | ||
| {post.title} |
src/components/PostsList.tsx
Outdated
|
|
||
| <tbody> | ||
| {posts.map(post => ( | ||
| <tr |
There was a problem hiding this comment.
Better move it to separate component Post
src/components/UserSelector.tsx
Outdated
Comment on lines
52
to
59
| <a | ||
| key={user.id} | ||
| href={`#user-${user.id}`} | ||
| className="dropdown-item" | ||
| onClick={() => updateUserAndPosts(user)} | ||
| > | ||
| {user.name} | ||
| </a> |
There was a problem hiding this comment.
Destructure user and move this code to common component User
DarkMistyRoom
suggested changes
Jan 17, 2024
| const [posts, setPosts] = useState<Post[]>([]); | ||
| const [comments, setComments] = useState<Comment[]>([]); | ||
| const [selectedUser, setSelectedUser] = useState<User | null>(null); | ||
| const [selectedPost, setSelectedPost] = useState<Post | null>(null); |
There was a problem hiding this comment.
I'm curious why do we need selectedPost when we have openPostId? Isn't it about the same selected/opened post?
src/components/NewCommentForm.tsx
Outdated
Comment on lines
21
to
23
| const [hasNameError, setHasNameError] = useState(false); | ||
| const [hasMailError, setHasMailError] = useState(false); | ||
| const [hasTextareaError, setHasTextareaError] = useState(false); |
There was a problem hiding this comment.
no need to store these in the state. These values are derived from above ones
| const [hasNameError, setHasNameError] = useState(false); | ||
| const [hasMailError, setHasMailError] = useState(false); | ||
| const [hasTextareaError, setHasTextareaError] = useState(false); | ||
| const [isAdding, setIsAdding] = useState(false); |
src/components/PostDetails.tsx
Outdated
Comment on lines
62
to
65
| {!error | ||
| && Boolean(comments.length) | ||
| && comments | ||
| && !isLoadingComments |
src/components/PostDetails.tsx
Outdated
Comment on lines
69
to
70
| {!error && Boolean(comments.length) | ||
| && !isLoadingComments |
src/components/PostsList.tsx
Outdated
|
|
||
| <tbody> | ||
| {posts.map(post => ( | ||
| <tr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEMO]https://Absolution26.github.io/react_dynamic-list-of-posts/