Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First try #1008

Closed
wants to merge 3 commits into from
Closed

First try #1008

wants to merge 3 commits into from

Conversation

SerhiiUnhurian
Copy link

No description provided.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there are no demo link here, also you need to add the demo link to the PR description
image

src/App.tsx Outdated
import { PostsList } from './components/PostsList';
import { PostDetails } from './components/PostDetails';
// import { PostDetails } from './components/PostDetails';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments everywhere

Suggested change
// import { PostDetails } from './components/PostDetails';

>
Something went wrong!
</div>
{postErrorMessage !== '' && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{postErrorMessage !== '' && (
{postErrorMessage && (

))}
</div>
)}
{/* <a href="#user-2" className="dropdown-item is-active">Ervin Howell</a> */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

Suggested change
{/* <a href="#user-2" className="dropdown-item is-active">Ervin Howell</a> */}

Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but fix prev comments please

src/App.tsx Outdated
import { PostsList } from './components/PostsList';
import { PostDetails } from './components/PostDetails';
// import { PostDetails } from './components/PostDetails';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not resolved
image

src/App.tsx Outdated
<div className="notification is-warning" data-cy="NoPostsYet">
No posts yet
</div>
{posts.length === 0 && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{posts.length === 0 && (
{!posts.length && (

))}
</div>
)}
{/* <a href="#user-2" className="dropdown-item is-active">Ervin Howell</a> */}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@SerhiiUnhurian SerhiiUnhurian closed this by deleting the head repository Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants