Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #535

wants to merge 1 commit into from

Conversation

indigo04
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the test script for the student registration page! 🎉 The code meets the task requirements and constraints, and you've done well in automating the form submission process. There are a couple of minor issues to address: the missing closing bracket in the hobbies checkbox selector and the potential issue with the date of birth input handling. These don't significantly impact the functionality, so I'm approving your PR. Keep up the good work and consider refining these areas for even better results! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

cy.get('#userNumber').type(phone);
cy.get('#dateOfBirthInput').type('{ENTER}');
cy.get('#subjectsInput').type(subject);
cy.get('[for="hobbies-checkbox-1"').click();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing closing bracket in the selector for the hobbies checkbox. It should be cy.get('[for="hobbies-checkbox-1"]').click();.

cy.get('#userEmail').type(email);
cy.get('[for="gender-radio-1"]').click();
cy.get('#userNumber').type(phone);
cy.get('#dateOfBirthInput').type('{ENTER}');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way the date of birth input is handled might not work as intended. Typing '{ENTER}' directly might not select a date. Consider using a more specific method to select a date, such as interacting with a date picker if available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants