solution #618
solution #618
Conversation
There was a problem hiding this comment.
Great job on implementing the test cases for the Sign In page! 🎉 Your code effectively covers the key scenarios of valid login, invalid login, and logout, meeting the task requirements. While there are a couple of minor issues, such as the generic selector for the logout button and the incorrect URL assertion, these do not significantly impact the functionality. Consider refining the selector to be more specific and correcting the URL assertion for better accuracy. Keep up the excellent work and continue refining your skills! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| it('should redirect to the correct site', () => { | ||
| cy.get('form').find('button[type="submit"]').click(); | ||
| cy.url().should('eq', rightSite); |
There was a problem hiding this comment.
The URL assertion is incorrect. The cy.url().should('eq', rightSite); should use cy.url().should('eq', rightSite); instead of cy.url().should('eq', rightSite);. Make sure to use cy.url().should('eq', rightSite); to correctly compare the current URL with the expected URL.
|
|
||
| it('should properly log out user', () => { | ||
| cy.get('.button').click(); |
There was a problem hiding this comment.
The selector .button for the logout button might be too generic. Ensure that this selector uniquely identifies the logout button to avoid potential issues if there are multiple elements with the same class.
No description provided.