Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create stopwatch #3660

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mykytalandar
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Your solution is almost there, but there are a few critical issues that need to be addressed before we can approve it. 🚀

  1. Animation Duration for Speed-Up Modifier: The speed-up modifier should set the animation duration for the minutes hand to 10min, but it's currently set to 10s. This needs to be corrected to ensure the stopwatch functions as intended.

  2. Keyframes Implementation: The task specifies using from/to for keyframes, but your code uses 0% and 100%. Please adjust this to meet the task requirements.

These changes are essential for the functionality and compliance with the task requirements. Once you've made these adjustments, your code will be ready for approval. Keep up the great work! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your progress! 🎉 The HTML and SCSS files are correctly structured and linked, and the stopwatch is centered with dimensions and styles matching the task requirements. However, there are a couple of critical issues to address:

  1. Animation Duration for Speed-Up Modifier: The speed-up modifier should set the animation duration for the minutes hand to 10min, but it's currently set to 10s. Please update --minute-duration to 10min to ensure the stopwatch functions as intended.

  2. Keyframes Implementation: The keyframes are now correctly implemented using from/to, which aligns with the task requirements.

Your solution is approved to help you move forward with your learning journey. Please review the comments and make the necessary improvements to enhance your code. Keep up the good work, and remember to address critical issues in future tasks to avoid similar problems. Happy coding! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +19 to +20
&--speed-up {
--minute-duration: 10s;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The speed-up modifier should set the animation duration for the minutes hand to 10min instead of 10s to ensure the stopwatch functions as intended. Please update --minute-duration to 10min.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants