-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create stopwatch #3660
base: master
Are you sure you want to change the base?
create stopwatch #3660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your solution is almost there, but there are a few critical issues that need to be addressed before we can approve it. 🚀
-
Animation Duration for Speed-Up Modifier: The
speed-up
modifier should set the animation duration for the minutes hand to10min
, but it's currently set to10s
. This needs to be corrected to ensure the stopwatch functions as intended. -
Keyframes Implementation: The task specifies using
from/to
for keyframes, but your code uses0%
and100%
. Please adjust this to meet the task requirements.
These changes are essential for the functionality and compliance with the task requirements. Once you've made these adjustments, your code will be ready for approval. Keep up the great work! 💪
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your progress! 🎉 The HTML and SCSS files are correctly structured and linked, and the stopwatch is centered with dimensions and styles matching the task requirements. However, there are a couple of critical issues to address:
-
Animation Duration for Speed-Up Modifier: The
speed-up
modifier should set the animation duration for the minutes hand to10min
, but it's currently set to10s
. Please update--minute-duration
to10min
to ensure the stopwatch functions as intended. -
Keyframes Implementation: The keyframes are now correctly implemented using
from/to
, which aligns with the task requirements.
Your solution is approved to help you move forward with your learning journey. Please review the comments and make the necessary improvements to enhance your code. Keep up the good work, and remember to address critical issues in future tasks to avoid similar problems. Happy coding! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
&--speed-up { | ||
--minute-duration: 10s; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The speed-up
modifier should set the animation duration for the minutes hand to 10min
instead of 10s
to ensure the stopwatch functions as intended. Please update --minute-duration
to 10min
.
No description provided.