Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gmaikovych
Copy link

  • DEMO LINK

  • Keyframes implemented using from/to + transform with rotate property

  • Stopwatch is centered and has the correct arrows size

  • All Typical Mistakes from the BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your project! 🎉 The structure and styling are well-implemented, and the animations are set up correctly. Just a small note: there's a typo in the animation name 'rotatating' which should be corrected to 'rotating'. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

z-index: -1;
bottom: 50%;

animation: rotatating var(--minutes-speed) steps(60) infinite;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the animation name 'rotatating'. It should be 'rotating' to match the keyframes defined below.

z-index: -1;
bottom: 50%;

animation: rotatating var(--seconds-speed) linear infinite;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the animation name 'rotatating'. It should be 'rotating' to match the keyframes defined below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants