Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #3651

wants to merge 1 commit into from

Conversation

vkysh
Copy link

@vkysh vkysh commented Feb 22, 2025

  • DEMO LINK
  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the [Code Style Rules ❗️]

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 The HTML and SCSS files are well-structured, and the stopwatch design meets the task requirements. Just make sure to define or import the missing variables like $second-color, $minute-color, $center-color, and $border-color to avoid any compilation errors. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

&__face {
width: $stopwatch-size;
height: $stopwatch-size;
border: 1vmin dotted $border-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $border-color is used here but is not defined in this file. Make sure to define it or import it from another file where it is defined.

&__center {
width: $center-size;
height: $center-size;
background-color: $center-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $center-color is used here but is not defined in this file. Ensure it is defined or imported from another file.

&--minutes {
width: $minute-width;
height: $minute-height;
background-color: $minute-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $minute-color is used here but is not defined in this file. Define it or import it from another file to avoid errors.

&--seconds {
width: $second-width;
height: $second-height;
background-color: $second-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $second-color is used here but is not defined in this file. Make sure it is defined or imported from another file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants