-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #3651
base: master
Are you sure you want to change the base?
add task solution #3651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 The HTML and SCSS files are well-structured, and the stopwatch design meets the task requirements. Just make sure to define or import the missing variables like $second-color
, $minute-color
, $center-color
, and $border-color
to avoid any compilation errors. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
&__face { | ||
width: $stopwatch-size; | ||
height: $stopwatch-size; | ||
border: 1vmin dotted $border-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $border-color
is used here but is not defined in this file. Make sure to define it or import it from another file where it is defined.
&__center { | ||
width: $center-size; | ||
height: $center-size; | ||
background-color: $center-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $center-color
is used here but is not defined in this file. Ensure it is defined or imported from another file.
&--minutes { | ||
width: $minute-width; | ||
height: $minute-height; | ||
background-color: $minute-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $minute-color
is used here but is not defined in this file. Define it or import it from another file to avoid errors.
&--seconds { | ||
width: $second-width; | ||
height: $second-height; | ||
background-color: $second-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $second-color
is used here but is not defined in this file. Make sure it is defined or imported from another file.
Typical Mistakes
from theBEM
lesson theory are checked.