Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopwatch #3650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

stopwatch #3650

wants to merge 1 commit into from

Conversation

AllanCordella
Copy link

❗️ Replace <your_account> with your GitHub username and copy the links to the Pull Request description:

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the stopwatch functionality! 🎉 Your code meets all the task requirements, and the animations look fantastic. Just a small note: remember to correct the self-closing <html> tag to ensure compatibility across all browsers. Keep up the excellent work, and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,5 +1,8 @@
<!doctype html>
<html lang="en">
<html

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <html> tag should not be self-closing. In HTML, the <html> tag should be written as <html> without a closing slash. Please remove the slash to ensure proper HTML syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants