-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #6111
base: master
Are you sure you want to change the base?
Develop #6111
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm test | ||
- name: Upload HTML report(backstop data) | ||
if: ${{ always() }} | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: report | ||
path: backstop_data |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,13 +10,109 @@ | |
http-equiv="X-UA-Compatible" | ||
content="ie=edge" | ||
/> | ||
<title>Moyo header</title> | ||
<title>Flexbox Header</title> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.googleapis.com" | ||
/> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.gstatic.com" | ||
/> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto&display=swap" | ||
rel="stylesheet" | ||
/> | ||
<link | ||
rel="stylesheet" | ||
href="./style.css" | ||
/> | ||
</head> | ||
<body> | ||
<h1>Moyo header</h1> | ||
<header class="header"> | ||
<a | ||
href="#" | ||
class="logo" | ||
> | ||
<img | ||
class="logo__img" | ||
src="images/logo.png" | ||
alt="logo" | ||
/> | ||
</a> | ||
<nav> | ||
<ul class="nav-list"> | ||
<li> | ||
<a | ||
href="/apple" | ||
class="nav-link is-active" | ||
> | ||
APPLE | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="/samsung" | ||
class="nav-link" | ||
> | ||
SAMSUNG | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="/smartphones" | ||
class="nav-link" | ||
> | ||
Smartphones | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav-link" | ||
data-qa="hover" | ||
href="/laptops" | ||
> | ||
Laptops & Computers | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="/gadgets" | ||
class="nav-link" | ||
> | ||
Gadgets | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="/tablets" | ||
class="nav-link" | ||
> | ||
Tablets | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="/photo" | ||
class="nav-link" | ||
> | ||
Photo | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
href="/video" | ||
class="nav-link" | ||
> | ||
Video | ||
</a> | ||
</li> | ||
</ul> | ||
</nav> | ||
</header> | ||
<main> | ||
<h1></h1> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
</main> | ||
<footer></footer> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,118 @@ | ||
body { | ||
html { | ||
box-sizing: border-box; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
font-size: 12px; | ||
} | ||
|
||
*, | ||
*::before, | ||
*::after { | ||
box-sizing: inherit; | ||
} | ||
|
||
body, | ||
h1, | ||
h2, | ||
h3, | ||
h4, | ||
h5, | ||
h6, | ||
p, | ||
ol, | ||
ul { | ||
margin: 0; | ||
padding: 0; | ||
font-weight: normal; | ||
} | ||
|
||
ol, | ||
ul { | ||
list-style: none; | ||
} | ||
|
||
img { | ||
max-width: 100%; | ||
height: auto; | ||
} | ||
|
||
:root { | ||
--blue: #007bff; | ||
} | ||
|
||
* { | ||
margin: 0; | ||
padding: 0; | ||
box-sizing: border-box; | ||
Comment on lines
+42
to
+43
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The universal selector |
||
} | ||
|
||
body { | ||
font-family: Roboto, sans-serif; | ||
font-size: 12px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the font-family 'Roboto' is consistent with the Google Fonts configuration in your HTML file. Verify that the font weights and styles match the requirements specified in the task description. |
||
} | ||
|
||
.header { | ||
display: flex; | ||
justify-content: space-between; | ||
align-items: center; | ||
padding: 0 50px; | ||
width: 100%; | ||
} | ||
|
||
.logo img { | ||
height: auto; | ||
width: 100%; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
.nav-list { | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
height: 60px; | ||
font-weight: 500; | ||
} | ||
|
||
.nav-link { | ||
display: inline-block; | ||
height: 60px; | ||
line-height: 60px; | ||
text-decoration: none; | ||
text-transform: uppercase; | ||
color: black; | ||
} | ||
|
||
.nav-link:hover { | ||
color: var(--blue); | ||
} | ||
|
||
.nav-link.is-active { | ||
color: var(--blue); | ||
position: relative; | ||
} | ||
|
||
.nav-list li:not(:last-child) { | ||
margin-right: 20px; | ||
} | ||
|
||
.nav-list li:first-child .nav-link { | ||
padding-left: 0; | ||
} | ||
|
||
.nav-list li:last-child .nav-link { | ||
padding-right: 0; | ||
} | ||
|
||
.nav-link.is-active::after { | ||
content: ''; | ||
background-color: var(--blue); | ||
border-radius: 4px; | ||
width: 100%; | ||
height: 4px; | ||
display: block; | ||
position: absolute; | ||
left: 0; | ||
bottom: 0; | ||
} | ||
|
||
[data-qa='hover'] { | ||
position: relative; | ||
top: 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
<h1>
tag is currently empty. It's important to provide meaningful content within this tag for accessibility and SEO purposes. Consider adding a relevant heading here.