Moyo header #5852

sdoskich · 2024-12-21T13:17:39Z

Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules
DEMO LINK
TEST REPORT LINK

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
_{[CODE: 10]}

Additional info:
Files with too large content:

reports/html_report/index_bundle.js

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
_{[CODE: 10]}

Additional info:
Files with too large content:

reports/html_report/index_bundle.js

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
_{[CODE: 10]}

Additional info:
Files with too large content:

reports/html_report/index_bundle.js

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

Too many changes in the pull request. Please make sure that you have added only the necessary changes to the pull request.
_{[CODE: 6]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

VitaliyBondarenko1982

Demo links is not correct.
Use demo links from readme.md file in project.

VitaliyBondarenko1982 · 2024-12-22T14:44:42Z

src/style.css

+  justify-content: flex-end;
+}
+
+.main-menu ul li {


style by classes instead tags

VitaliyBondarenko1982 · 2024-12-22T14:45:55Z

src/style.css

+  width: 100%;
+  height: 8px;
+  background-color: #00acdc;
+  bottom: -18.5px;


Suggested change

bottom: -18.5px;

bottom: 0;

links shuld have height on full header height. so bottom shouldn't be hardcoded and should be 0.

etojeDenys

you need to pass all tests, don't hesitate to ask for some help in the chat

sdoskich · 2024-12-24T13:16:39Z

Please, tell me what I have to do next.

etojeDenys

create a thread in the mate chat and ping me there in comments, will try to help with those tests

anastasiiavorobiova

Feel free to ask for help in the chat to pass all tests

anastasiiavorobiova · 2025-02-08T11:13:16Z

src/index.html

+          <li class="main-menu__item">
+            <a
+              href="#"
+              class="is-active"


Suggested change

class="is-active"

class="is-active main-menu__item"

anastasiiavorobiova · 2025-02-08T11:13:33Z

src/index.html

+              href="#"
+              data-qa="hover"
+            >
+              <span class="highlight">Laptops & Computers</span>


Suggested change

<span class="highlight">Laptops & Computers</span>

Laptops & Computers

anastasiiavorobiova · 2025-02-08T11:14:20Z

src/index.html

+              Apple
+            </a>
+          </li>
+          <li class="main-menu__item"><a href="#">Samsung</a></li>


Suggested change

<li class="main-menu__item"><a href="#">Samsung</a></li>

<li class="main-menu__item"><a class="main-menu__link" href="#">Samsung</a></li>

Consider using classes for styling links

anastasiiavorobiova · 2025-02-08T11:14:40Z

src/style.css

+  margin-right: 0;
+}
+
+.main-menu ul li a {


Suggested change

.main-menu ul li a {

.main-menu__link {

anastasiiavorobiova · 2025-02-08T11:14:50Z

src/style.css

+}
+
+.main-menu ul li a {
+  font-family: Roboto, Arial, Helvetica, sans-serif;


Suggested change

font-family: Roboto, Arial, Helvetica, sans-serif;

anastasiiavorobiova · 2025-02-08T11:14:57Z

src/style.css

+  color: #000;
+  font-weight: 500;
+  font-size: 12px;
+  height: 54px;


Suggested change

height: 54px;

anastasiiavorobiova · 2025-02-08T11:15:13Z

src/style.css

+}
+
+.highlight {
+  color: #00acdc;


Consider using variables for repeating colors

sdoskich · 2025-02-08T12:24:57Z

Будь ласка допоможіть вирішити завдання. Вже дуже довго я не можу це зробити. А допомого немає!

vadiimvooo

Seems like there are no fixes since last review. Please feel free to ask for help in fe_chat. Mentors will help you to solve the issue.

volodymyr-soltys97

Hi, the font styles looks different as on the design, pls feel free in the fe_chat for help

sdoskich · 2025-02-09T09:18:33Z

Останні результати тестів. Чому вибиває старий макет не знаю. Диплой я зробив і вроді все має працювати. Як це вирішити. З чату допомоги ніякоЇ. ХЕЛП!

sdoskich · 2025-02-09T09:20:15Z

anastasiiavorobiova

Consider fixing previous comments
I've launched the project locally and it doesn't pass the tests

Feel free to ask for help in the chat to redeploy your solution

sdoskich added 4 commits December 1, 2024 01:39

Header task completed

22bf131

Fix style changes in style.css

48dc591

Updated style.css

681bc50

Fix CSS linting issue

a9832ab

mateacademy-ai-mentor reviewed Dec 21, 2024

View reviewed changes

sdoskich added 2 commits December 21, 2024 14:42

Remove large files from the repository

aa7302e

Fix large files issue and update .gitignore

ce47477

mateacademy-ai-mentor reviewed Dec 21, 2024

View reviewed changes

Ignore large file and remove from repo

37fff96

mateacademy-ai-mentor reviewed Dec 21, 2024

View reviewed changes

VitaliyBondarenko1982 suggested changes Dec 22, 2024

View reviewed changes

sdoskich added 3 commits December 23, 2024 13:57

Refactor styles to use classes instead of tags

8cd57f1

Set links to have full header height by removing hardcoded bottom value

f46c21a

Add BackstopJS configuration and reference images

25bf4ee

sdoskich requested review from VitaliyBondarenko1982 and mateacademy-ai-mentor December 23, 2024 16:08

sdoskich added 3 commits December 23, 2024 19:22

Moved files to docs folder

d85935f

Updated repository with latest changes

443fae1

Add BackstopJS tests and update configuration

dac891c

etojeDenys suggested changes Dec 23, 2024

View reviewed changes

sdoskich requested a review from etojeDenys December 24, 2024 13:22

etojeDenys suggested changes Dec 24, 2024

View reviewed changes

sdoskich added 2 commits February 3, 2025 21:04

1

d2bae2b

Merge branch 'master' into master

56ab9e0

sdoskich requested a review from etojeDenys February 8, 2025 10:22

index_bundle.js

124446d

anastasiiavorobiova suggested changes Feb 8, 2025

View reviewed changes

sdoskich requested a review from anastasiiavorobiova February 8, 2025 11:50

vadiimvooo suggested changes Feb 8, 2025

View reviewed changes

sdoskich added 6 commits February 8, 2025 14:54

Update package-lock.json

4831804

Updated layout and styles

2e047ba

Changed Apple text color to blue and fixed spacing

65657a0

Merge completed

4207061

Added text-transform: uppercase for navigation menu

0328740

Updated bottom value in main-menu ul li:hover::after to 20px

cac3228

sdoskich requested a review from vadiimvooo February 8, 2025 21:02

sdoskich added 3 commits February 8, 2025 22:29

Fix BackstopJS config, add approve script

8ead38e

add BackstopJS report

c7a200c

Added BackstopJS report

6b56b1e

volodymyr-soltys97 suggested changes Feb 9, 2025

View reviewed changes

sdoskich requested a review from volodymyr-soltys97 February 9, 2025 09:18

anastasiiavorobiova suggested changes Feb 9, 2025

View reviewed changes

Updated CSS styles

7936a57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Moyo header #5852

Moyo header #5852

sdoskich commented Dec 21, 2024 •

edited

Loading

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

VitaliyBondarenko1982 left a comment

VitaliyBondarenko1982 Dec 22, 2024

VitaliyBondarenko1982 Dec 22, 2024

etojeDenys left a comment

sdoskich commented Dec 24, 2024

etojeDenys left a comment

anastasiiavorobiova left a comment

anastasiiavorobiova Feb 8, 2025

anastasiiavorobiova Feb 8, 2025

anastasiiavorobiova Feb 8, 2025

anastasiiavorobiova Feb 8, 2025

anastasiiavorobiova Feb 8, 2025

anastasiiavorobiova Feb 8, 2025

anastasiiavorobiova Feb 8, 2025

sdoskich commented Feb 8, 2025

vadiimvooo left a comment

volodymyr-soltys97 left a comment

sdoskich commented Feb 9, 2025

sdoskich commented Feb 9, 2025

anastasiiavorobiova left a comment

	<span class="highlight">Laptops & Computers</span>
	Laptops & Computers

	<li class="main-menu__item"><a href="#">Samsung</a></li>
	<li class="main-menu__item"><a class="main-menu__link" href="#">Samsung</a></li>

Moyo header #5852

Are you sure you want to change the base?

Moyo header #5852

Conversation

sdoskich commented Dec 21, 2024 • edited Loading

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etojeDenys left a comment

Choose a reason for hiding this comment

sdoskich commented Dec 24, 2024

etojeDenys left a comment

Choose a reason for hiding this comment

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdoskich commented Feb 8, 2025

vadiimvooo left a comment

Choose a reason for hiding this comment

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

sdoskich commented Feb 9, 2025

sdoskich commented Feb 9, 2025

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

sdoskich commented Dec 21, 2024 •

edited

Loading