Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with services #915

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/mate/academy/service/AuthenticationService.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
import mate.academy.model.User;

public class AuthenticationService {
private User user;

public boolean login(String email, String password) {
UserService userService = new UserService();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make user a private field instead of a local variable

// Find the user by email
User user = userService.findByEmail(email);

// Check if the user exists and the provided password matches the user's password
return user != null && user.getPassword().equals(password);
this.user = userService.findByEmail(email);

return this.user != null && this.user.getPassword().equals(password);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this out to know where we need this
https://stackoverflow.com/a/2411283
when we don't, no need to use it

}
}
Loading