write in AuthenticationService - login method and in class UserServic… #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e - findByEmail method
kozhukhovsky
suggested changes
Jan 16, 2024
| return false; | ||
| boolean existUser; | ||
|
|
||
| UserService users = new UserService(); |
Comment on lines
19
to
20
| User equalsUser; | ||
| equalsUser = users.findByEmail(email); |
There was a problem hiding this comment.
Suggested change
| User equalsUser; | |
| equalsUser = users.findByEmail(email); | |
| User user = users.findByEmail(email); |
| return false; | ||
| boolean existUser; | ||
|
|
||
| UserService users = new UserService(); |
There was a problem hiding this comment.
Suggested change
| UserService users = new UserService(); | |
| UserService userService = new UserService(); |
| @@ -11,6 +13,18 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| boolean existUser; | |||
There was a problem hiding this comment.
Suggested change
| boolean existUser; |
There was a problem hiding this comment.
in this recommendation,i understand what you mean
| User equalsUser; | ||
| equalsUser = users.findByEmail(email); | ||
|
|
||
| if (equalsUser.getPassword() == password) { |
Comment on lines
22
to
28
| if (equalsUser.getPassword() == password) { | ||
| existUser = true; | ||
| } else { | ||
| existUser = false; | ||
| } | ||
|
|
||
| return existUser; |
There was a problem hiding this comment.
Suggested change
| if (equalsUser.getPassword() == password) { | |
| existUser = true; | |
| } else { | |
| existUser = false; | |
| } | |
| return existUser; | |
| return user != null && user.getPassword().equals(password); |
okuzan
suggested changes
Jan 16, 2024
| @@ -11,6 +16,9 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| UserService usersService = new UserService(); | |||
There was a problem hiding this comment.
not fixed, make it a private class-level field, not a local variable - so we can reuse it, not recreate per each method call
| return false; | ||
| UserService usersService = new UserService(); | ||
| User user = usersService.findByEmail(email); | ||
| existUser = Objects.equals(user.getPassword(), password); |
There was a problem hiding this comment.
I believe we aren't allowed to use Objects class in this task 🥲
Comment on lines
18
to
25
| User returnedUser = new User(null,null); | ||
|
|
||
| for (User user : users) { | ||
| if (email.equals(user.getEmail())) { | ||
| returnedUser = user; | ||
| } | ||
| } | ||
| return returnedUser; |
There was a problem hiding this comment.
Suggested change
| User returnedUser = new User(null,null); | |
| for (User user : users) { | |
| if (email.equals(user.getEmail())) { | |
| returnedUser = user; | |
| } | |
| } | |
| return returnedUser; | |
| for (User user : users) { | |
| if (email.equals(user.getEmail())) { | |
| return user; | |
| } | |
| } | |
| return null; |
okuzan
suggested changes
Jan 17, 2024
| public class AuthenticationService { | ||
| private boolean existUser; |
There was a problem hiding this comment.
Suggested change
| private boolean existUser; |
Comment on lines
20
to
27
| if (user != null) { | ||
| if (user.getPassword() == password) { | ||
| existUser = true; | ||
| } | ||
| } else { | ||
| existUser = false; | ||
| } | ||
| return existUser; |
There was a problem hiding this comment.
Suggested change
| if (user != null) { | |
| if (user.getPassword() == password) { | |
| existUser = true; | |
| } | |
| } else { | |
| existUser = false; | |
| } | |
| return existUser; | |
| return user != null && user.getPassword() == password; |
okuzan
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e - findByEmail method