fixed problem with AuthenticationService and UserService #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan95kos
suggested changes
Jan 7, 2024
| new User("[email protected]", "1234") | ||
| }; | ||
| new User("[email protected]", "1234")}; | ||
| private User foundUser; |
There was a problem hiding this comment.
useless variable
Suggested change
| private User foundUser; |
| return null; | ||
| for (User user : users) { | ||
| if (user.getEmail().equals(email)) { | ||
| foundUser = user; |
There was a problem hiding this comment.
Suggested change
| foundUser = user; | |
| return user; |
| foundUser = user; | ||
| } | ||
| } | ||
| return foundUser; |
There was a problem hiding this comment.
Suggested change
| return foundUser; | |
| return null; |
Comment on lines
19
to
24
| if (userService.findByEmail(email).getEmail().equals(email) | ||
| && userService.findByEmail(email).getPassword().equals(password)) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
redundant operation
Suggested change
| if (userService.findByEmail(email).getEmail().equals(email) | |
| && userService.findByEmail(email).getPassword().equals(password)) { | |
| return true; | |
| } else { | |
| return false; | |
| } | |
| User user = userService.findByEmail(email); | |
| return user != null && user.getPassword().equals(password); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.