Login and find user services created #899
Conversation
| @@ -10,7 +12,14 @@ public class AuthenticationService { | |||
| * @return true if user by email exists and passed password is equal to user's password. | |||
| * Return false in any other cases. | |||
| */ | |||
| private UserService usersData = new UserService(); | |||
There was a problem hiding this comment.
Let's call just this variable as it is - userService
Because it's not just the data, it also has a functionality that we can and should use :)
| for (User user: usersData.getUsers()) { | ||
| if (user.getEmail().equals(email) && user.getPassword().equals(password)) { | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's use findByEmail() method from userService to not duplicate our logic and here we can just do the null check and password check
| for (User user: usersData.getUsers()) { | |
| if (user.getEmail().equals(email) && user.getPassword().equals(password)) { | |
| return true; | |
| } | |
| } |
|
|
||
| public User[] getUsers() { | ||
| return users; | ||
| } |
There was a problem hiding this comment.
And we can remove this method
| public User[] getUsers() { | |
| return users; | |
| } |
| // I'm not sure what better, to call 2 times find by email | ||
| // methoud, or made an instance of find by email result? | ||
| if (userService.findByEmail(email) != null) { | ||
| if (userService.findByEmail(email).getPassword().equals(password)) { |
There was a problem hiding this comment.
we should always strive for DRY principle - which stands for Don't Repeat Yourself, including situations like this, when we can put the result of this method in a variable to not call it 2 times
Also, we can remove those if statements, combine their condition into a single one and return it's result right away :)
| return true; | ||
| } | ||
| } | ||
|
|
| return null; | ||
| } | ||
|
|
No description provided.