Hometask done #898

skucherenko7 · 2024-01-06T16:13:06Z

No description provided.

Sanderfuck · 2024-01-07T10:17:29Z

src/main/java/mate/academy/service/UserService.java

+        int i = 0;
+        while (i < users.length) {
+            if (users[i].getEmail().equals(email)) {
+                return users[i];
+            }
+            i++;
+        }


Here you better use for each loop

Sanderfuck · 2024-01-07T10:19:08Z

src/main/java/mate/academy/service/AuthenticationService.java

     */
    public boolean login(String email, String password) {
-        return false;
+        UserService userService = new UserService();


UserService should be class field

Sanderfuck · 2024-01-07T10:20:47Z

src/main/java/mate/academy/service/AuthenticationService.java

+        return Objects.requireNonNull(UserService.findByEmail(email)).getEmail().equals(email)
+                && Objects.requireNonNull(UserService.findByEmail(email)).getPassword()
+                .equals(password);


You don`t need use class Objects here, at first you can get user form UserService.findByEmail(email) anf after this compare his password

kerrrusha · 2024-01-09T17:22:08Z

src/main/java/mate/academy/service/UserService.java

+
+        for (User user: users) {
+            if (user.getEmail().equals(email)) {
+                return user;
+            }
+        }
+


redundant blank lines

Suggested change

for (User user: users) {

if (user.getEmail().equals(email)) {

return user;

}

}

for (User user: users) {

if (user.getEmail().equals(email)) {

return user;

}

}

kerrrusha · 2024-01-09T17:24:43Z

src/main/java/mate/academy/service/AuthenticationService.java

+
+        if (userService.findByEmail(email).getPassword().equals(password)) {
+            return true;
+        }
        return false;
    }
 }
+
+


many redundant blank lines

we will get NPE if userService.findByEmail(email) returns null. save returned user to the variable and check for nullability

kerrrusha · 2024-01-09T17:24:56Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -1,16 +1,20 @@
 package mate.academy.service;

 public class AuthenticationService {
+    private static final UserService userService = new UserService();


Suggested change

private static final UserService userService = new UserService();

private final UserService userService = new UserService();

Rommelua · 2024-01-10T10:38:14Z

src/main/java/mate/academy/service/AuthenticationService.java

@@ -1,16 +1,20 @@
 package mate.academy.service;

 public class AuthenticationService {
+    private static final UserService userService = new UserService();


Rommelua · 2024-01-10T10:38:21Z

src/main/java/mate/academy/service/AuthenticationService.java

+
+        if (userService.findByEmail(email).getPassword().equals(password)) {
+            return true;
+        }
        return false;
    }
 }
+
+


Rommelua · 2024-01-10T10:38:32Z

src/main/java/mate/academy/service/UserService.java

+
+        for (User user: users) {
+            if (user.getEmail().equals(email)) {
+                return user;
+            }
+        }
+


Sanderfuck · 2024-01-10T11:44:36Z

src/main/java/mate/academy/model/User.java

+    private final String email;
+    private final String password;


Don`t change it

Should I need to remove final? What can I do?

Sanderfuck · 2024-01-10T11:46:14Z

src/main/java/mate/academy/service/AuthenticationService.java

+        if (userService.findByEmail(email).getPassword().equals(password)) {
+            return true;
+        }


Suggested change

if (userService.findByEmail(email).getPassword().equals(password)) {

return true;

}

if (user.getPassword().equals(password)) {

return true;

}

You already have a user, you don`t need use "userService.findByEmail(email)" anymore

After this write the return condition in one line, you don`t need write return 2 times

Sanderfuck · 2024-01-10T11:48:26Z

src/main/java/mate/academy/service/UserService.java

@@ -3,18 +3,17 @@
 import mate.academy.model.User;

 public class UserService {
-    private static final User[] users = new User[] {
+    private final User[] users = new User[] {


Don`t change it

I changed and removed static. What should I do else?

Here is marked as static

I removed static a long time ago. I don't understand why you don't see it

kerrrusha · 2024-01-10T18:07:38Z

src/main/java/mate/academy/service/AuthenticationService.java

+        if (userService.findByEmail(email).getPassword().equals(password)) {
+            return true;
+        }


# Conflicts: # src/main/java/mate/academy/service/AuthenticationService.java

kerrrusha · 2024-01-10T18:55:48Z

src/main/java/mate/academy/service/AuthenticationService.java

+        if (user.getPassword().equals(password)) {
+            return true;
+        }
        return false;


add check for user != null

inline it

Sanderfuck · 2024-01-11T12:28:09Z

src/main/java/mate/academy/service/UserService.java

@@ -3,18 +3,17 @@
 import mate.academy.model.User;

 public class UserService {
-    private static final User[] users = new User[] {
+    private final User[] users = new User[] {


Here is marked as static

Sanderfuck · 2024-01-11T12:29:07Z

src/main/java/mate/academy/model/User.java

+    private final String email;
+    private final String password;


Sanderfuck · 2024-01-11T12:31:36Z

src/main/java/mate/academy/service/AuthenticationService.java

+        if (user != null && user.getPassword().equals(password)) {
+            return true;
+        }
        return false;


Here, it looks great, can you simplify it by writing in one line with return? After this you don`t need to write return 2 times) If you need some help better ask it in chat

sokimaaa

not fixed prev comments

sokimaaa · 2024-01-11T18:52:35Z

src/main/java/mate/academy/service/AuthenticationService.java

+        if (user != null && user.getPassword().equals(password)) {
+            return true;
+        }
        return false;


Hometask done

b8a76bd

Sanderfuck suggested changes Jan 7, 2024

View reviewed changes

Chenges homework

384404f

skucherenko7 requested a review from Sanderfuck January 9, 2024 16:16

Chenges homework

eb22271

kerrrusha suggested changes Jan 9, 2024

View reviewed changes

Chenges homework

bb0baf6

skucherenko7 requested a review from kerrrusha January 9, 2024 19:09

Rommelua suggested changes Jan 10, 2024

View reviewed changes

Chenges2 homework

0304e41

skucherenko7 requested a review from Rommelua January 10, 2024 10:46

Sanderfuck suggested changes Jan 10, 2024

View reviewed changes

skucherenko7 requested a review from Sanderfuck January 10, 2024 12:47

kerrrusha suggested changes Jan 10, 2024

View reviewed changes

skucherenko7 requested a review from kerrrusha January 10, 2024 18:29

skucherenko7 added 2 commits January 10, 2024 20:36

Chenges4 homework

951754f

Merge remote-tracking branch 'origin/master'

7743f3b

# Conflicts: # src/main/java/mate/academy/service/AuthenticationService.java

kerrrusha suggested changes Jan 10, 2024

View reviewed changes

Chenges4 homework

a635b43

skucherenko7 requested a review from kerrrusha January 10, 2024 20:07

Sanderfuck suggested changes Jan 11, 2024

View reviewed changes

Chenges4 homework

18ab614

skucherenko7 requested a review from Sanderfuck January 11, 2024 15:03

sokimaaa suggested changes Jan 11, 2024

View reviewed changes

Chenges homework1

0b08715

skucherenko7 requested a review from sokimaaa January 11, 2024 19:09

sokimaaa approved these changes Jan 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hometask done #898

Hometask done #898

skucherenko7 commented Jan 6, 2024

Sanderfuck Jan 7, 2024

Sanderfuck Jan 7, 2024

Sanderfuck Jan 7, 2024

kerrrusha Jan 9, 2024

Rommelua Jan 10, 2024

kerrrusha Jan 9, 2024

Rommelua Jan 10, 2024

kerrrusha Jan 9, 2024

Rommelua Jan 10, 2024

Rommelua Jan 10, 2024

Rommelua Jan 10, 2024

Rommelua Jan 10, 2024

Sanderfuck Jan 10, 2024

skucherenko7 Jan 10, 2024

Sanderfuck Jan 11, 2024

Sanderfuck Jan 10, 2024

Sanderfuck Jan 10, 2024

Sanderfuck Jan 10, 2024

kerrrusha Jan 10, 2024

Sanderfuck Jan 10, 2024

skucherenko7 Jan 10, 2024

Sanderfuck Jan 11, 2024

skucherenko7 Jan 11, 2024

kerrrusha Jan 10, 2024

kerrrusha Jan 10, 2024

Sanderfuck Jan 11, 2024

Sanderfuck Jan 11, 2024

Sanderfuck Jan 11, 2024

sokimaaa Jan 11, 2024

sokimaaa left a comment

sokimaaa Jan 11, 2024

	private static final UserService userService = new UserService();
	private final UserService userService = new UserService();

Hometask done #898

Are you sure you want to change the base?

Hometask done #898

Conversation

skucherenko7 commented Jan 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sokimaaa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment