HW2 #894
Open
HW2 #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add code to Aunthentication Service and User Service |
okuzan
suggested changes
Jan 5, 2024
Comment on lines
9
to
26
| public static class User { | ||
| private final String email; | ||
| private final String password; | ||
|
|
||
| public User(String email, String password) { | ||
| this.email = email; | ||
| this.password = password; | ||
| } | ||
|
|
||
| public String getEmail() { | ||
| return email; | ||
| } | ||
|
|
||
| public String getPassword() { | ||
| return password; | ||
| } | ||
| } | ||
|
|
| @@ -11,6 +11,11 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
| @@ -11,6 +11,11 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
| UserService.User user = userService.findByEmail(email); | |||
There was a problem hiding this comment.
Suggested change
| UserService.User user = userService.findByEmail(email); | |
| User user = userService.findByEmail(email); |
Comment on lines
16
to
19
| if (user != null && user.getPassword().equals(password)) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
you can return condition directly ,without using true/false literals
kozhukhovsky
approved these changes
Feb 15, 2024
Comment on lines
+18
to
+19
|
|
||
|
|
| return null; | ||
| } | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add code to Aunthentication Service and User Service