-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add verify #1153
add verify #1153
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,7 +14,12 @@ public class UserService { | |||||
* @return - user if his email is equal to passed email. | ||||||
* Return <code>null</code> if there is no suitable user | ||||||
*/ | ||||||
public User findByEmail(String email) { | ||||||
return null; | ||||||
public static User findByEmail(String email) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
for (User u : users) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
avoid short one-letter naming, readability is important |
||||||
if (email.equals(u.getEmail())) { | ||||||
return u; | ||||||
} | ||||||
} | ||||||
return new User("NoNe", ""); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what should you return, if there is no match? read the comment again carefully |
||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will get NPE after refactoring UserService, so you'll need to make changes here too