Tests added #121
Tests added #121
Conversation
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
Something went wrong while processing the review.
[CODE: 3]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
Something went wrong while processing the review.
[CODE: 3]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
Something went wrong while processing the review.
[CODE: 3]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Thank you for your hard work on this! 😊 There are a few critical issues with the test cases that need to be addressed before we can proceed. Specifically, some test cases expect the function to return true for emails ending with a period, which contradicts the task requirements. Please update these test cases to use valid email formats. Once these changes are made, your solution will be ready for approval. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/validateEmail.test.js
Outdated
| @@ -8,13 +9,38 @@ describe(`Function 'validateEmail':`, () => { | |||
| }); | |||
|
|
|||
| it(`should return boolean`, () => { | |||
|
|
|||
| expect(typeof validateEmail('[email protected].')).toBe('boolean'); | |||
There was a problem hiding this comment.
The test case checks if the function returns a boolean, which is correct. However, the email used here ends with a period, which is not a valid email format according to the task description. Consider using a valid email format for this test.
src/validateEmail.test.js
Outdated
| }); | ||
|
|
||
| it(`should return 'true' for the valid email`, () => { | ||
| expect(validateEmail('[email protected].')) | ||
| .toBeTruthy(); | ||
| expect(validateEmail('[email protected].')).toBeTruthy(); |
There was a problem hiding this comment.
This test case expects the function to return 'true' for an email ending with a period, which is incorrect according to the task description. An email should not end with a period. Please update the test case to use a valid email format.
| }); | ||
|
|
||
| it(`should return 'true' if mail name contain one latin symbol`, () => { | ||
| expect(validateEmail('[email protected]')).toBeTruthy(); |
There was a problem hiding this comment.
The test case checks if the function returns 'true' for an email with a single Latin character before the '@' symbol. Ensure this aligns with the task requirements, as the description does not explicitly mention this case.
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code in validateEmail.test.js meets the task requirements and constraints, effectively testing the validateEmail function. The test cases cover the necessary scenarios, ensuring that valid email formats return true and invalid ones return false.
However, there are a few points to consider for improvement:
- Ensure all test cases align with the task requirements, particularly regarding valid and invalid email formats.
- The test case on line 24 correctly expects
falsefor an email ending with a period, which is in line with the task requirements.
These issues are not critical, but addressing them will enhance the quality of your code. Keep up the good work, and make sure to review the comments to refine your skills further. Remember, learning from these experiences will help you avoid similar issues in the future. Keep coding and improving! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| it(`should return 'false' for the invalid email`, () => { | ||
| expect(validateEmail('[email protected]')).toBeFalsy(); |
There was a problem hiding this comment.
The test case correctly expects false for an email ending with a period. Ensure that this aligns with the task requirements.
Tests added