Solution #5245
Solution #5245
Conversation
| @@ -4,7 +4,23 @@ | |||
| * @return {number} | |||
| */ | |||
| function calculateRentalCost(days) { | |||
| // write code here | |||
| const dailyRate = 40; | |||
There was a problem hiding this comment.
For const variables it is better to use this name format 'DAILY_RATE'
There was a problem hiding this comment.
Great job on implementing the calculateRentalCost function! 🎉 Your code is well-structured, with clear variable names and a good use of constants. While the discount logic might need a review to ensure it aligns with the intended business rules, the core functionality is solid. Keep up the good work, and consider revisiting the discount application order to make sure it meets the requirements. Happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (days >= longTerm) { | ||
| return rentAmount - longTermDiscount; | ||
| } | ||
|
|
||
| if (days >= shortTerm) { | ||
| return rentAmount - shortTermDiscount; | ||
| } |
There was a problem hiding this comment.
The logic for applying discounts might be incorrect. Currently, if days is greater than or equal to longTerm, the function will apply the long-term discount and return immediately, without checking if the short-term discount should also be applied. Ensure that the discount logic aligns with the intended business rules. If both discounts should not be applied simultaneously, consider revising the conditions.
No description provided.