Solution #5191
Solution #5191
Conversation
There was a problem hiding this comment.
Your implementation of the calculateRentalCost function is well-structured and meets the task requirements effectively! 🎉 The use of descriptive names and constants is excellent, ensuring clarity and maintainability. The logic for applying discounts is correct, assuming the intention is to apply only one discount based on the rental period. If you intended to apply both discounts for longer rentals, you might want to adjust the logic. Keep up the great work, and consider this small tweak if it aligns with your goals! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (days >= LONG_TERM) { | ||
| return basePrice - LONG_TERM_DISCOUNT; | ||
| } | ||
|
|
||
| if (days >= SHORT_TERM) { | ||
| return basePrice - SHORT_TERM_DISCOUNT; | ||
| } |
There was a problem hiding this comment.
The current logic applies a long-term discount if the rental period is 7 days or more, and a short-term discount if it is 3 days or more. However, this means that a rental period of 7 days will only receive the long-term discount, not both. If this is intended, the logic is correct. Otherwise, consider revising the logic to apply both discounts if applicable.
No description provided.