Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution by Kickstarter #477

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

daryna-kopytko
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, your demo link isn't working, you need to make a deploy and check after the demo
image

@TarasHoliuk
Copy link

  1. Clicking on the logo leads to 404 page. Logo should always be a home link (# anchor link in this case):

image

  1. You change font-weight on hover for nav links. As a result, it moves surrounding elements (a bit, but it's visible). Also, it's not efficient for performance (the browser will redraw the entire page with every change). Use transform/opacity/color to improve it.

image

  1. Export from figma and use SVG images for icons (for better quality):
    image

4 Open link in the new tab for all external resources (it's a general rule). The Facebook icon is squeezed:

image

  1. Implement the menu for mobile version (now the button does nothing):
    image

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍 Added a few comments to improve your landing page

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Need to open these additional links in the new tab
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. After submit the form don't need refresh page and scroll to top, you need only reset form fields
image

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants