Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #473

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #473

wants to merge 5 commits into from

Conversation

lishvets
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Dec 21, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2024-12-21 at 16 53 44
  • Check font here
  • Screenshot 2024-12-21 at 16 53 20
  • Transitions between anchor links should be smooth
  • Screenshot 2024-12-21 at 16 53 07
  • A user shouldn't be able to resize the text area
  • Screenshot 2024-12-21 at 16 52 50
  • Consider removing default outlines
  • Screenshot 2024-12-21 at 16 52 41
  • Consider adding hover styles here
  • Screenshot 2024-12-21 at 16 52 32
  • Check the layout here
  • Screenshot 2024-12-21 at 16 52 26
  • The hover shouldn't affect other elements
  • Screenshot 2024-12-21 at 16 52 16
  • Consider removing default borders here
  • The hover effect should be smooth

VitaliyBondarenko1982
VitaliyBondarenko1982 suggested changes Dec 22, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong with styles.
Try to make some small changes in project and redeploy again.
Screenshot 2024-12-22 at 17 23 13

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Dec 24, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lishvets @VitaliyBondarenko1982 @anastasiiavorobiova