Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #444

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Develop #444

wants to merge 12 commits into from

Conversation

myuriy81
Copy link

@myuriy81 myuriy81 commented Aug 9, 2024

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. apply cursor:pointer for all interactable elements
  2. add paddings for input
    image
    3.get rid of horizontal scroll

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scroll is still exist
image

@myuriy81
Copy link
Author

Но у меня нет скрола? где он?

Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@myuriy81 myuriy81 requested a review from IvanFesenko August 14, 2024 12:42
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-08-14 at 16 19 16
Screenshot 2024-08-14 at 16 19 21
Check the layout for mobiles
Screenshot 2024-08-14 at 16 16 45
The hover shouldn't have an impact on other elements
Screenshot 2024-08-14 at 16 16 39
Consider removing default borders

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Add transition for all hover effects on the page
image image
  1. The user cannot be able to change size of the textarea field
image
  1. Check color for these icons on the layout, add hover effects here and these links must be open in the new tab
image
  1. Add hover effects for all clickable elements
image
  1. Fix the background width here
image

Layout
image

@TarasHoliuk
Copy link

1 (mandatory). When you click on the anchor link the scroll should be smooth

2 (optionally). I'd recommend you setting 100% width for the blue background in this section in the mobile version instead of hardcoded 320px. So it'll look better on phones with a bit bigger width:

image

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 🔥
One more thing is required to fix. Also, added 1 suggestion

@myuriy81 myuriy81 requested a review from TarasHoliuk August 15, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants