Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #435

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Develop #435

wants to merge 26 commits into from

Conversation

Aleksandra-hub
Copy link

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. all external links should be open in a new tab
    image
  2. Fix mobile version of this section
    image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-07-19 at 16 48 46
Screenshot 2024-07-19 at 16 48 52
Check the layout for tablets
Screenshot 2024-07-19 at 16 48 00
Screenshot 2024-07-19 at 16 48 05
Check fonts here
Screenshot 2024-07-19 at 16 47 26
Check the button size here
Screenshot 2024-07-19 at 16 47 13
A user should be able to scroll the menu
Screenshot 2024-07-19 at 16 46 40
Check fonts here. Consider removing default outlines
Screenshot 2024-07-19 at 16 46 27
Consider adding transition here on hovers
Screenshot 2024-07-19 at 16 46 03
Screenshot 2024-07-19 at 16 46 09
Check the alignment here

Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

  1. Consider adding some hover effects for this card
    image

  2. Same here
    image

  3. Consider adding some action for this button
    image

  4. Consider making fixed height for this block and change only text inside with out height jumping
    image

  5. Consider fixing your logic with left/right padding
    image

@Aleksandra-hub Aleksandra-hub requested a review from GUSILLUS July 26, 2024 08:55
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. After submitting form you don't need to refresh and scroll to top page, you need just clear form fields

  2. Add some hover effects here

image
  1. The content should stretch to the full width, there should not be a white bar on the right
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no commit from the previous review, you need to push your code and make a deploy again after your changes
image

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but seems like you have not fixed a few last comments.

1.Change the autofill styles for the form fields
css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers
3.Add some hover effects here

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants