Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inheritance of sidekiq securityContext #76

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

roobre
Copy link
Contributor

@roobre roobre commented Jul 6, 2023

values.yaml says:

  sidekiq:
    # -- Pod security context for all Sidekiq Pods, overwrites .Values.podSecurityContext
    podSecurityContext: {}
    # -- (Sidekiq Container) Security Context for all Pods, overwrites .Values.securityContext
    securityContext: {}

However, this was not true before this PR: Only sidekiq.securityContext was considered, defaulting to an empty security context if it was not set.

@timetinytim
Copy link
Contributor

Ah good catch, thank you!

@timetinytim timetinytim merged commit 93bda60 into mastodon:main Apr 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants