Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing default gas cost for some abis #4761

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Add missing default gas cost for some abis #4761

merged 6 commits into from
Oct 10, 2024
+94 −6

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Oct 9, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Leo-Besancon
Leo-Besancon approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, useful script!

@sydhds sydhds merged commit ca70988 into mainnet_2_3 Oct 10, 2024
12 checks passed
@sydhds sydhds deleted the feature/inconsistent_gas_entries branch October 10, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @Leo-Besancon