New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix join error message (was inconsistent with: VM controller … #4756

Merged

sydhds merged 1 commit into mainnet_2_3 from revert-4744-feature/exec_manager_join_expect_msg_1

Oct 2, 2024

Contributor

sydhds commented Oct 2, 2024

…thread)"

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          Revert "Fix join error message (was inconsistent with: VM controller …

8ad6eaa

…thread)"

sydhds merged commit 2664915 into mainnet_2_3

4 checks passed

sydhds deleted the revert-4744-feature/exec_manager_join_expect_msg_1 branch

October 2, 2024 08:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet