Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix join error message (was inconsistent with: VM controller thread) #4744

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Fix join error message (was inconsistent with: VM controller thread) #4744

merged 6 commits into from
Oct 2, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Sep 19, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Leo-Besancon
Leo-Besancon previously approved these changes Sep 19, 2024
View reviewed changes
@Leo-Besancon
Copy link
Contributor

Approved the change, I think just the fmt that isn't happy but otherwise ok!

Leo-Besancon and others added 6 commits October 2, 2024 10:20
@Leo-Besancon @sydhds
Fix slot index position status (#4736)
b6b8fa6 
* Fix SlotIndexPosition from Future to Past in case slots_since returns an error

* Update ci.yml
@Leo-Besancon @sydhds
Validate that hd_cache_size >= snip_amount (#4732)
8c32b89
@Leo-Besancon @sydhds
Improve handling of HistorySearchResult for fetched executed_ops/denu…
2d94edd 
…nciations (#4735)

* Improve handling of HistorySearchResult

* Fix CI
@Leo-Besancon @sydhds
Update ASC trigger comment (#4740)
d98df3b 
* Update ASC trigger comment

* Add comment for ledger entry deletions

* fmt
@sydhds
Fix join error message (was inconsistent with: VM controller thread)
8612838
@sydhds
Cargo fmt pass
f29a0b3
@sydhds sydhds changed the base branch from main to mainnet_2_3 October 2, 2024 08:21
@sydhds sydhds force-pushed the feature/exec_manager_join_expect_msg_1 branch from 4b98b3c to f29a0b3 Compare October 2, 2024 08:21
@sydhds sydhds merged commit cca6d89 into mainnet_2_3 Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilboquet bilboquet bilboquet approved these changes

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @Leo-Besancon @bilboquet