Runtime changes common #4180
Merged
Runtime changes common #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVM signatures verification
damip
reviewed
Jun 30, 2023
massa-execution-exports/Cargo.toml
Outdated
| @@ -27,7 +27,7 @@ massa_final_state = { path = "../massa-final-state" } | |||
| massa_ledger_exports = { path = "../massa-ledger-exports", optional = true } | |||
| massa_module_cache = { path = "../massa-module-cache" } | |||
| massa_versioning = { path = "../massa-versioning" } | |||
| massa-sc-runtime = { git = "https://github.com/massalabs/massa-sc-runtime", branch = "main" } | |||
| massa-sc-runtime = { git = "https://github.com/massalabs/massa-sc-runtime", branch = "feature/Improve_ABI_types_in_wasmv1" } | |||
There was a problem hiding this comment.
/!\ Do not merge until we:
- Merge the massa-sc-runtime common branch into main
- Update the Cargo.toml with a rev of the massa-sc-runtime commit / (or we target main instead?)
damip
reviewed
Jun 30, 2023
damip
reviewed
Jun 30, 2023
* Update interface impl for leo's changes Depends on feature/Improve_ABI_types_in_wasmv1 branch for massa-sc-runtime and massa-proto-rs Signed-off-by: Jean-François Morcillo <[email protected]> Update target branch Implemented the interface for my new ABIs Added prefix to get_op_keys_wasmv1 Update target branch Update in_downtime context value Add some unit tests Use helper function to get address Added comments and deprecation notice Target new runtime rev to have consistant proto-rs targets Simplified a bit the prefix logic Based on review comments * Fix after rebase --------- Co-authored-by: Jean-François Morcillo <[email protected]>
Authored-by: Jean-François Morcillo <[email protected]>
* fmt * Update branch targeting * Implement abis * Update interface (clippy, implem some abis..) * fmt * Changed back branch targeting
Co-authored-by: Jean-François Morcillo <[email protected]>
* Implement unsafe_random_wasmv1 * Added doc comments and deprecation notes
Signed-off-by: Jean-François Morcillo <[email protected]>
…ssa::hash) Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Leo-Besancon
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.