Feature/namecard comment #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
그리고 방명록 조회할 때, isMine만 같이 내려주면 해당 댓글이 사용자가 작성한 것인지 아닌건지에 대한 것에 따라 서버에서 따로 처리할 것 없이 클라쪽에서 이후에 해당 사용자가 작성한 것이 아니면 댓글에 대한 수정 작업을 할 수 없게한다던가 해서 처리해주는 것 아닌가용? |
god9599
reviewed
Apr 22, 2022
god9599
reviewed
May 14, 2022
Comment on lines
+28
to
+38
| @ApiProperty({ example: '공개여부' }) | ||
| @IsString() | ||
| @IsNotEmpty() | ||
| @Column({ default: false }) | ||
| isPrivate: boolean; | ||
|
|
||
| @ApiProperty({ example: '고정여부' }) | ||
| @IsString() | ||
| @IsNotEmpty() | ||
| @Column({ default: false }) | ||
| isFix: boolean; |
There was a problem hiding this comment.
boolean type인데 @IsString()이 걸려있네욜
| @Column() | ||
| nameCardId: number; | ||
|
|
||
| isMine?: boolean; |
There was a problem hiding this comment.
요거는 별도의 데코레이터 사용이 안되어있는 이유가 있나요?
| HttpStatus, | ||
| Injectable, | ||
| } from '@nestjs/common'; | ||
| import { HttpErrorByCode } from '@nestjs/common/utils/http-error-by-code.util'; |
Comment on lines
+62
to
+70
| if (fixedComments.length >= 3) { | ||
| throw new HttpException( | ||
| { | ||
| status: HttpStatus.NOT_ACCEPTABLE, | ||
| error: '명함의 방명록은 3개까지만 상단 고정이 가능합니다.', | ||
| }, | ||
| HttpStatus.NOT_FOUND, | ||
| ); | ||
| } |
There was a problem hiding this comment.
3개까지니까 > 로 해야하지 않나용? 그리고 status code를 다른 걸로 수정해야 할 것 같어요
Comment on lines
-19
to
+38
| makeFirstNameCard: userOnboardingStatusType; | ||
| makeFirstNameCard: 'WAIT' | 'DONE_WAIT' | 'DONE'; | ||
|
|
||
| @IsNotEmpty() | ||
| @IsString() | ||
| @Column({ default: 'WAIT' }) | ||
| saveMeetuMyAlbum: userOnboardingStatusType; | ||
| saveMeetuMyAlbum: 'WAIT' | 'DONE_WAIT' | 'DONE'; | ||
|
|
||
| @IsNotEmpty() | ||
| @IsString() | ||
| @Column({ default: 'WAIT' }) | ||
| addFriendNameCard: userOnboardingStatusType; | ||
| addFriendNameCard: 'WAIT' | 'DONE_WAIT' | 'DONE'; | ||
|
|
||
| // @IsNotEmpty() | ||
| // @IsString() | ||
| // @Column({ default: 'WAIT' }) | ||
| // makeNewCollection: userOnboardingStatusType; | ||
| // makeNewCollection: 'WAIT' | 'DONE_WAIT' | 'DONE'; | ||
|
|
||
| @IsNotEmpty() | ||
| @IsString() | ||
| @Column({ default: 'WAIT' }) | ||
| makeThreeNameCards: userOnboardingStatusType; | ||
| makeThreeNameCards: 'WAIT' | 'DONE_WAIT' | 'DONE'; |
| @@ -13,6 +13,8 @@ export interface NameCardSchema { | |||
| contacts: ContactSchema[]; | |||
| tmis: TmiSchema[]; | |||
| personalSkills: PersonalSkillSchema[]; | |||
| commentCount?: number; | |||
There was a problem hiding this comment.
optional이 필요한가?? 없는 건 걍 0주면 될 것 같은데
god9599
reviewed
May 14, 2022
| @@ -3,6 +3,7 @@ import { createParamDecorator, ExecutionContext } from '@nestjs/common'; | |||
| export const AuthUser = createParamDecorator( | |||
| (data: unknown, ctx: ExecutionContext) => { | |||
| const request = ctx.switchToHttp().getRequest(); | |||
| request.user = { id: 1 }; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
위 5가지 API를 작업하였습니다