Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/get top keywords #6

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Feature/get top keywords #6

merged 5 commits into from
Jun 20, 2024

Conversation

pjw5521
Copy link
Contributor

@pjw5521 pjw5521 commented Jun 17, 2024

  • add keyword model
  • add getTopKeywords api

@Hyun-git Hyun-git changed the base branch from main to develop June 18, 2024 04:20
Hyun-git
Hyun-git approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@Hyun-git Hyun-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳..! 로거만 넣어줭~

seohyun0120
seohyun0120 reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@seohyun0120 seohyun0120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어!

src/model/keyword.ts Outdated Show resolved Hide resolved
Hyun-git
Hyun-git approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@Hyun-git Hyun-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳 고생했엉~~

@seohyun0120
Copy link
Collaborator

고생했어!

@seohyun0120 seohyun0120 self-requested a review June 20, 2024 13:21
@pjw5521 pjw5521 merged commit ee00363 into develop Jun 20, 2024
1 check passed
@pjw5521 pjw5521 deleted the feature/getTopKeywords branch June 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyun-git Hyun-git Hyun-git approved these changes

@seohyun0120 seohyun0120 seohyun0120 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjw5521 @seohyun0120 @Hyun-git