-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
밈 저장 취소 시 성공했음에도 false로 반환되는 문제, 밈 조회 시 isSaved 필드가 제대로 동작하지않는 문제 수정 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seohyun0120
changed the title
밈 저장 취소 시 성공했음에도 false로 반환되는 문제 수정, 밈 조회 시 isSaved 필드가 제대로 동작하지않는 문제 수정
밈 저장 취소 시 성공했음에도 false로 반환되는 문제, 밈 조회 시 isSaved 필드가 제대로 동작하지않는 문제 수정
Jul 23, 2024
추천 밈 보기 로직 개선, MemeRecommendWatchModel schema 변경
Hyun-git
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생했옹ㅇ
@@ -44,6 +47,33 @@ export const getRequestedMemeInfo = async ( | |||
next(); | |||
}; | |||
|
|||
// getRequestedMemeInfo, getRequestedUserInfo 미들웨어가 먼저 불려야함 | |||
export const getRequestedMemeSaveInfo = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NotDeleted가 들어가면 좋긴 할것 같아용! deleted된걸 조회하는 것도 있으니
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
버그
200
상태코드와data: false
가 넘어오는 문제가 있어서 수정isSaved: true
로 넘어오는 문제가 있어서 수정개선