Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API별 헤더 추가, MemeInteractionService 추가 #28

Merged
merged 14 commits into from
Jul 14, 2024

Conversation

seohyun0120
Copy link
Collaborator

@seohyun0120 seohyun0120 commented Jul 14, 2024

개선

  • ...s -> ...List 로 변수명 함수명 변경
  • MemeInteraction Service 구현, 다른 service단에서 직접 MemeInteractionModel 사용하지않도록 변경
  • IMemeGetResponse 타입 수정, IMemeInteraction Schema 선언 수정
  • null 체크를 lodash _.isNull 쓰도록 명시적으로 변경

버그

  • swagger에 header 없는 api 추가
  • 내가 저장한 밈인지 조회하는 코드에서 쿼리 조건 수정 (type 필드가 아닌 interactionType임)
  • 테스트 코드 수정

정책 변경

없음

@seohyun0120 seohyun0120 changed the title Feature/add header update interaction API별 헤더 추가, MemeInteractionService 추가 Jul 14, 2024
@seohyun0120 seohyun0120 merged commit f19c8e7 into develop Jul 14, 2024
1 check passed
@seohyun0120 seohyun0120 deleted the feature/add-header-update-interaction branch July 16, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant