-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #201 from mash-up-kr/feature/duplicated-protecting
feat: protect duplicated request
- Loading branch information
Showing
9 changed files
with
114 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
piikii-input-http/src/main/kotlin/com/piikii/input/http/aspect/PreventDuplicateAspect.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| package com.piikii.input.http.aspect | ||
|
|
||
| import com.piikii.common.exception.ExceptionCode | ||
| import com.piikii.common.exception.PiikiiException | ||
| import org.aspectj.lang.ProceedingJoinPoint | ||
| import org.aspectj.lang.annotation.Around | ||
| import org.aspectj.lang.annotation.Aspect | ||
| import org.aspectj.lang.reflect.MethodSignature | ||
| import org.springframework.context.expression.MethodBasedEvaluationContext | ||
| import org.springframework.core.DefaultParameterNameDiscoverer | ||
| import org.springframework.expression.spel.standard.SpelExpressionParser | ||
| import org.springframework.stereotype.Component | ||
| import java.util.concurrent.ConcurrentHashMap | ||
| import java.util.concurrent.Executors | ||
| import java.util.concurrent.TimeUnit | ||
| import java.util.concurrent.TimeoutException | ||
|
|
||
| /** | ||
| * 중복요청 방지 제어 Annotation | ||
| * | ||
| * @property key key to determine duplicate requests (support SpEL) | ||
| * @property timeoutMillis default 7 seconds | ||
| */ | ||
| @Target(AnnotationTarget.FUNCTION) | ||
| @Retention(AnnotationRetention.RUNTIME) | ||
| annotation class PreventDuplicateRequest( | ||
| val key: String, | ||
| val timeoutMillis: Long = 7_000, | ||
| ) | ||
|
|
||
| @Aspect | ||
| @Component | ||
| class PreventDuplicateAspect { | ||
| private val processingRequests = ConcurrentHashMap.newKeySet<String>() | ||
| private val parser = SpelExpressionParser() | ||
| private val parameterNameDiscoverer = DefaultParameterNameDiscoverer() | ||
| private val executor = Executors.newVirtualThreadPerTaskExecutor() | ||
|
|
||
| @Around("@annotation(PreventDuplicateRequest)") | ||
| fun preventDuplicateRequest(joinPoint: ProceedingJoinPoint): Any? { | ||
| val signature = joinPoint.signature as MethodSignature | ||
| val method = signature.method | ||
| val annotation = method.getAnnotation(PreventDuplicateRequest::class.java) | ||
| val key = generateKey(joinPoint, signature, annotation) | ||
|
|
||
| if (!processingRequests.add(key)) { | ||
| // if exists, throw Duplicated Request Exception | ||
| throw PiikiiException(ExceptionCode.DUPLICATED_REQUEST) | ||
| } | ||
|
|
||
| val future = executor.submit<Any> { joinPoint.proceed() } | ||
| try { | ||
| return future.get(annotation.timeoutMillis, TimeUnit.MILLISECONDS) | ||
| } catch (e: TimeoutException) { | ||
| future.cancel(true) | ||
| throw PiikiiException(ExceptionCode.REQUEST_TIMEOUT) | ||
| } finally { | ||
| processingRequests.remove(key) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * 중복 요청으로 판단할 key 생성 | ||
| * - method name + SpEL parsed value | ||
| * | ||
| * @param joinPoint | ||
| * @param signature | ||
| * @param annotation | ||
| * @return Key to determine duplicate requests | ||
| */ | ||
| private fun generateKey( | ||
| joinPoint: ProceedingJoinPoint, | ||
| signature: MethodSignature, | ||
| annotation: PreventDuplicateRequest, | ||
| ): String { | ||
| val method = signature.method | ||
| val expression = parser.parseExpression(annotation.key) | ||
| val context = | ||
| MethodBasedEvaluationContext( | ||
| joinPoint.target, | ||
| method, | ||
| joinPoint.args, | ||
| parameterNameDiscoverer, | ||
| ) | ||
| val parsedValue = | ||
| expression.getValue(context, String::class.java) | ||
| ?: throw PiikiiException( | ||
| ExceptionCode.NOT_FOUNDED, | ||
| "중복요청 계산에 사용될 key가 없습니다 (method: ${method.name}, annotation key: ${annotation.key})", | ||
| ) | ||
| return "${method.name}_$parsedValue" | ||
| } | ||
| } |
2 changes: 1 addition & 1 deletion
2
...piikii/input/http/web/config/WebConfig.kt → ...com/piikii/input/http/config/WebConfig.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../input/http/web/advice/ExceptionAdvice.kt → ...http/controller/advice/ExceptionAdvice.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters