fix: 당근 랭킹 1위 멤버 스케줄러 버그 수정

mash-up-kr · Aug 15, 2024 · cdac7f1 · cdac7f1
1 parent eb67d4c
commit cdac7f1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/mashup-domain/src/main/java/kr/mashup/branding/service/popup/MemberPopupService.java b/mashup-domain/src/main/java/kr/mashup/branding/service/popup/MemberPopupService.java
@@ -31,8 +31,4 @@ public Boolean isEnabledMemberPopup(Member member, PopupType popupType) {
 		// 페이지에 방문하지 않은 경우(팝업 상태 활성화) && 마지막으로 본 일자가 현재 보다 과거인 경우
 		return memberPopup.get().getIsEnabled() && memberPopup.get().getLastViewedAt().toLocalDate().isBefore(LocalDate.now());
 	}
-
-	public void save(Member member, PopupType popupType) {
-		memberPopupRepository.save(MemberPopup.of(true, LocalDateTime.now().minusDays(1), member, popupType));
-	}
 }
diff --git a/...r/src/main/java/kr/mashup/branding/facade/danggn/DanggnRankingSchedulerFacadeService.java b/...r/src/main/java/kr/mashup/branding/facade/danggn/DanggnRankingSchedulerFacadeService.java
@@ -52,7 +52,7 @@ public void updateFirstMember() {
                     Member firstScoredMember = firstScore.getMemberGeneration().getMember();
                     DanggnRankingReward danggnRankingReward = DanggnRankingReward.from(firstScoredMember.getId(), currentGeneration.getId());
                     danggnRankingRewardService.save(danggnRankingReward);
-                    memberPopupService.save(firstScoredMember, PopupType.DANGGN_REWARD);
+                    memberPopupService.findOrSaveMemberPopupByMemberAndType(firstScoredMember, PopupType.DANGGN_REWARD);
                 }
             }
         });